Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scummvm scraping attempting to scrape internal game files #1575

Open
3 tasks done
medeirosT opened this issue May 6, 2024 · 1 comment
Open
3 tasks done

Scummvm scraping attempting to scrape internal game files #1575

medeirosT opened this issue May 6, 2024 · 1 comment
Assignees
Labels
bug in onion Something isn't working

Comments

@medeirosT
Copy link

Checklist

  • I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
  • I have reviewed the Onion Docs and did not find the answer
  • I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.3.0

Miyoo Firmware Version

202306282128

Provide a clear and concise description of the issue

I am scraping my ScummVM games and it seems the scraping script goes through internal files as it attempts to scrape covers for these games.

Steps to Reproduce

  • Add new ScummVM games
  • Run import script
  • Within ScummVM game list, press Y and begin the scraping process of all games

You will see it attempting to scan internal game files to those scummvm games AS games and fail

Provide any additional context or information that may help us investigate your issue

PXL_20240506_183735711

@XK9274 XK9274 added the bug in onion Something isn't working label May 8, 2024
@medeirosT
Copy link
Author

I think the issue might be the maxdepth here:

https://github.com/OnionUI/Onion/blob/main/static/build/.tmp_update/script/scraper/scrap_launchbox.sh#L243

maybe add a special clause if it is a scummvm rom?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug in onion Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants