Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add new overlays #1101

Merged
merged 2 commits into from
Sep 21, 2023
Merged

FEAT: Add new overlays #1101

merged 2 commits into from
Sep 21, 2023

Conversation

sinedied
Copy link
Contributor

@sinedied sinedied commented Aug 4, 2023

Add new set of overlays:

  • GBA_REAL made by me: realistic and bright pixel grid overlays for GBA, with or without GBA logo
  • Perfect_CRT made by 1playerinsertcoin: realistic and bright CRT overlay with scanlines and phosphor effect without color deviation, with or without rounded frame

For the Perfect_CRT one its author gave me its consent for this PR here: https://www.reddit.com/r/MiyooMini/comments/15gq899/comment/juoftas/?context=3, and I credited him in the commit

a8bit
a8bit reviewed Aug 11, 2023
View reviewed changes
Copy link

@a8bit a8bit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great on the Mini+ The perfect CRT is now my default for non LCD systems.

XK9274
XK9274 requested changes Sep 19, 2023
View reviewed changes
Copy link
Member

@XK9274 XK9274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, testing these now - could you move those CRT overlays into the 4-3 CRT folder please? I'll then approve

image

@sinedied
Copy link
Contributor Author

@XK9274 I made the change, and rebased the branch so it's up to date.

XK9274
XK9274 approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@XK9274 XK9274 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers.

These look great, thanks for dropping the PR and ty to 1playerinsertcoin for creating them!

@Aemiii91 Aemiii91 added this pull request to the merge queue Sep 21, 2023
Merged via the queue into OnionUI:main with commit dc96ee0 Sep 21, 2023
2 checks passed
@Aemiii91 Aemiii91 added the enhancement New or improved feature label Oct 3, 2023
@dormk23 dormk23 mentioned this pull request Oct 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a8bit a8bit a8bit left review comments

@XK9274 XK9274 XK9274 approved these changes

Assignees
No one assigned
Labels
enhancement New or improved feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sinedied @a8bit @XK9274 @Aemiii91