Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 752x560 resolution used by new MMv4 screens #1272

Merged
merged 23 commits into from
Dec 22, 2023

Conversation

tGecko
Copy link
Member

@tGecko tGecko commented Nov 10, 2023

Support for 752x560 resolution.

On startup, runtime checks the physical screen resolution and stores it to /tmp/screen_resolution
If the firmware is 202310271401 and the physical resolution is 752x560, it also creates the flag /tmp/new_res_available

If this flag is set on game launch, the resolution is changed and keymon and batmon are informed of this via signal so they can update their stored resolutions.

Keymon was updated to respect the render resolution when drawing the brightness bar, batmon was updated to respect the render resolution when drawing the "battery empty" icon.

TODO:

  • implement either a blacklist for anything hardcoded to 640x480 or a whitelist for anything that supports 752x560?
    so far only drastic is added as exception.

  • testing, finding edge cases, other resolution dependent things?

  • overlays

@tGecko tGecko changed the title Support for 752x560 resolution used by new MMv4 screens FEAT: Support for 752x560 resolution used by new MMv4 screens Nov 10, 2023
@tGecko tGecko marked this pull request as ready for review November 22, 2023 08:15
@XK9274 XK9274 added the enhancement New or improved feature label Dec 3, 2023
@XK9274 XK9274 added this to the v4.3 milestone Dec 3, 2023
Copy link
Member

@schmurtzm schmurtzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome feature for v4 users !
I would prefer to invert the compatibility list : a whitelist of all the apps compatible with 560p but given that it is technically complex to set up and the fact that compatibility seems excellent, it will do the trick 👍🏻.

@schmurtzm schmurtzm added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 44a4620 Dec 22, 2023
3 checks passed
@schmurtzm schmurtzm deleted the MMv4_res_support branch December 22, 2023 00:06
@tGecko tGecko changed the title FEAT: Support for 752x560 resolution used by new MMv4 screens Add support for 752x560 resolution used by new MMv4 screens Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants