Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional password authentication to Telnet #861

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Add optional password authentication to Telnet #861

merged 2 commits into from
Jun 1, 2023

Conversation

XK9274
Copy link
Member

@XK9274 XK9274 commented May 31, 2023

Auth login
image

Non-auth Login
image
Tweaks_009
Tweaks_008

Adds:

  • Optional authentication functionality to telnet incase telnet gets left enabled/forgotten about on public/open wifi..
  • On-boot check for the firmware version of telnetd and kills it, relaunching with a script that sets env vars and time/date

Files added

  • telnetlogin.sh (Loaded from update_networking.sh check_telnetstate when auth is enabled)
  • telnetenv.sh (Loaded from update_networking.sh check_telnetstate when auth is disabled to set environment up)
  • .auth.txt (contains 2 account, both are used by FTP but only the first is used by telnet)

Other changes

  • Removed odd case on settings state files & in update_networking

Usage

  • telnet currently must be restarted if auth is enabled/disabled for the change to take effect.
  • Start telnet and Enable auth and you'll have the option to login to 1 account (onionusr from /mnt/SDCARD/.tmp_update/config/.auth.txt, default pwd onionos)
  • Passwords can (and should) be changed in .tmp_update/config/.auth.txt

Issues

  • telnet doesn't support TLS/encryption so the password can be seen in plain text should you use it on a public network if someone is watching...
  • The password will only stop entry, it's important to understand telnet won't protect/encrypt the traffic.

## Adds:
- Optional authentication functionality to telnet incase telnet gets left enabled/forgotten about on public/open wifi..
- On-boot check for the firmware version of telnetd and kills it, relaunching with a script that sets env vars and time/date

## Files added
- telnetlogin.sh (Loaded from update_networking.sh check_telnetstate when auth is enabled)
- telnetenv.sh (Loaded from update_networking.sh check_telnetstate when auth is disabled to set environment up)
- .auth.txt (contains 2 account, both are used by FTP but only the first is used by telnet)

## Other changes
- Removed odd case on settings state files & in update_networking

## Usage
- telnet currently must be restarted if auth is enabled/disabled for the change to take effect.
- Start telnet and Enable auth and you'll have the option to login to 1 account (onionusr from /mnt/SDCARD/.tmp_update/config/.auth.txt, default pwd onions)
- Passwords can (and should) be changed in .tmp_update/config/.auth.txt

## Issues
- telnet doesn't support TLS so the password can be seen in plain text should you use it on a public network if someone is watching...
- The password will only stop entry, it's important to understand telnet won't protect/encrypt the traffic.
@XK9274 XK9274 requested a review from Aemiii91 May 31, 2023 19:16
Aemiii91
Aemiii91 previously approved these changes Jun 1, 2023
@Aemiii91 Aemiii91 merged commit 0827b6e into OnionUI:main Jun 1, 2023
@Aemiii91 Aemiii91 added the enhancement New or improved feature label Oct 3, 2023
@XK9274 XK9274 deleted the telnet-add-login-screen branch March 12, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New or improved feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants