Fix: The long delay in/out of Tweaks when network services changed #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was caused by NTP not being backgrounded - it was called in by update_networking.sh to update the time but in the wrong place, so when the state of a toggle was changed ntpdate ran but in the FG instead of BG, when the process dies the UI frees up. - Moved ntpdate into the check_ntpstate func, it runs often (when network state is changed in tweaks) but this will ensure time is kept closely in line with NTP, it's a self terminating process so won't hang around long. - Backgrounded 2 calls of ntpdate
schmurtzm
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by NTP not being backgrounded - it was called in by update_networking.sh to update the time but in the wrong place, so when the state of a toggle was changed ntpdate ran but in the FG instead of BG, when the process dies the UI frees up.
Moved ntp into the check_ntpstate func, it runs often (when network state is changed in tweaks) but this will ensure time is kept closely in line with NTP, it's a self terminating process so won't hang around long.
Backgrounded 2 calls of ntp