Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update COMMODORE config.json: add extlist #967

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Update COMMODORE config.json: add extlist #967

merged 2 commits into from
Jun 30, 2023

Conversation

mjkaye
Copy link
Contributor

@mjkaye mjkaye commented Jun 30, 2023

Add extlist to COMMODORE config.json. Matches the supported extensions documented in the wiki.

@mjkaye
Update COMMODORE config.json: add extlist
a685e2b 
Add extlist to COMMODORE config.json. Matches the supported extensions documented in the wiki.
Aemiii91
Aemiii91 requested changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The uppercase extensions are not needed.

@mjkaye
Copy link
Contributor Author

mjkaye commented Jun 30, 2023

The uppercase extensions are not needed.

I've now removed them.

Aemiii91
Aemiii91 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@Aemiii91 Aemiii91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I'm surprised we didn't have this filled out.

@Aemiii91 Aemiii91 enabled auto-merge June 30, 2023 15:48
@Aemiii91 Aemiii91 added this pull request to the merge queue Jun 30, 2023
Merged via the queue into OnionUI:main with commit 8023618 Jun 30, 2023
2 checks passed
@Aemiii91 Aemiii91 added the bug in onion Something isn't working label Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aemiii91 Aemiii91 Aemiii91 approved these changes

Assignees
No one assigned
Labels
bug in onion Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjkaye @Aemiii91