feat: upgrade doc store #282
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const documentStore = await DocumentStoreFactory.connect(address, wallet); | ||
| const documentStore = await OwnableFactory.connect(address, wallet); |
There was a problem hiding this comment.
Why change DocumentStoreFactory to OwnableFactory in this PR? Do you mind sharing the rationale behind making this change?
There was a problem hiding this comment.
the dist/types/contracts/DocumentStore.d.ts definition file doesn't contain definitions for transferOwnership, but it's mentioned in the README.md file, so i'm presuming transferOwnership has been inherited on the smart contract, but is inaccessible in the definition files.
or has the contract switched to inherit DocumentStoreAccessControl .sol for ownership instead ?
There was a problem hiding this comment.
Oh… No more using transferOwnership. Use grantRole and revokeRole instead if you wish to change someone’s access roles.
The transferOwnership shouldn’t be in the readme. I will update the readme for document store tomorrow when I have time.🤞
| info( | ||
| `Find more details at ${getEtherscanAddress({ | ||
| network: args.network, | ||
| })}/tx/${grantTransactionHash} (grant) and ${getEtherscanAddress({ | ||
| network: args.network, | ||
| })}/tx/${revokeTransactionHash} (revoke)` | ||
| ); |
There was a problem hiding this comment.
Should we send the output as soon as the grant transaction is completed instead of waiting for both to finish then show them together? I'm thinking what if grant was successful but revoke failed? Then the display for the first successful transaction won't be known?
There was a problem hiding this comment.
Should the transfer-ownership command have its own tests too?
There was a problem hiding this comment.
i've created transfer-ownership as a new implementation as opposed to using grant and revoke seperately. tests written
|
The readme file may need to be updated with the new usage too. After the readme is updated, it should be good to go. |
|
added in information on grant, revoke and transfer ownership |
|
🎉 This PR is included in version 2.6.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Upgrade Document Store to v2.6.1
Changes
Issues
document-creator-website
tradetrust-website
TradeTrust/document-creator-website#297