Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack traces in (error) logs #512

Open
soxofaan opened this issue Sep 26, 2023 · 3 comments
Open

Stack traces in (error) logs #512

soxofaan opened this issue Sep 26, 2023 · 3 comments
Labels
job management incl. /result minor requires a minor-version (x.1.0 for example) service management
Milestone

Comments

@soxofaan
Copy link
Member

(Follow-up issue for #455)

As mentioned in #455 putting full error stack traces in log messages is not a good idea, we should spec out a separate field for that.

@m-mohr m-mohr added this to the 1.3.0 milestone Sep 26, 2023
@m-mohr m-mohr added job management incl. /result service management minor requires a minor-version (x.1.0 for example) labels Sep 30, 2023
@m-mohr
Copy link
Member

m-mohr commented Oct 19, 2023

Hmm, while I like getting rid of the stack traces in messages, I'm not sure whether they actually need to be exposed to users?
Can't you just generate a unique per log, put it in the id field and store the stack trace internally?

@jdries
Copy link

jdries commented Oct 20, 2023

I think they should be exposed. We have one user segment of advanced coders that are used to dealing with stack traces. Their main criticism of openEO is that it's a 'black box', which makes them feel out of control. Giving the possibility to see stack traces would make a connection to the open source code which they can then inspect and even improve.

There's also the case of UDF's: there it is in fact the user code that can generate stack traces, so they need to see them to resolve issues.

@m-mohr
Copy link
Member

m-mohr commented Oct 20, 2023

Okay, I'll buy that. UDFs is a really compelling argument. Then let's find a definition for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
job management incl. /result minor requires a minor-version (x.1.0 for example) service management
Projects
None yet
Development

No branches or pull requests

3 participants