Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Duplicate models are produced when a file is referenced multiple times by different paths #18948

Open
5 of 6 tasks
ctreatma opened this issue Jun 17, 2024 · 0 comments
Open
5 of 6 tasks

Comments

@ctreatma
Copy link
Contributor

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
  • [Optional] Sponsorship to speed up the bug fix or feature request (example)
Description

A recent openapi-generator release upgraded swagger-parser to 2.1.22. That upgrade resolved a bug where the parser was unable to resolve relative refs to real file paths, but it introduced a new bug where the parser creates duplicate schema objects for each unique relative path, rather than reusing an existing schema when two (or more) relative paths are equivalent.

openapi-generator version

v7.5.0

OpenAPI declaration file content or url

Refer to swagger-api/swagger-parser#2105 for a reproduction OpenAPI spec.

Generation Details
Steps to reproduce
Related issues/PRs
Suggest a fix

I don't think there's a way to work around this issue in openapi-generator itself; instead it requires a fix in swagger-parser that is then pulled in to this project in a future parser upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant