Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge submodule and update rocksdb using cmake #1211

Closed
kernelai opened this issue Nov 29, 2022 · 4 comments
Closed

merge submodule and update rocksdb using cmake #1211

kernelai opened this issue Nov 29, 2022 · 4 comments

Comments

@kernelai
Copy link
Collaborator

kernelai commented Nov 29, 2022

goal:

  • merge pink 、slash、blackwidow into pika repository
  • update rocksdb.
  • support cmake

env:
ubuntu 22.04.1 LTS
g++ version: g++ 11.3.0
rocksdb version : v7.7.3

@kernelai
Copy link
Collaborator Author

when merge blackwidow , found error
[build] /home/kernelai/github.com/pika/src/blackwidow/src/db_checkpoint.cc:21:10: fatal error: util/file_util.h: No such file or directory [build] 21 | #include "util/file_util.h" [build] | ^~~~~~~~~~~~~~~~~~ [build] compilation terminated.

@kernelai
Copy link
Collaborator Author

kernelai commented Nov 30, 2022

when merge blackwidow , found error [build] /home/kernelai/github.com/pika/src/blackwidow/src/db_checkpoint.cc:21:10: fatal error: util/file_util.h: No such file or directory [build] 21 | #include "util/file_util.h" [build] | ^~~~~~~~~~~~~~~~~~ [build] compilation terminated.

modify

#include util/file_util.h
#include util/filename.h

to

#include "file/file_util.h"
#include "file/filename.h"

@kernelai
Copy link
Collaborator Author

kernelai commented Nov 30, 2022

error:

In file included from /home/kernelai/github.com/pika/src/blackwidow/src/blackwidow.cc:9:
[build] /home/kernelai/github.com/pika/src/blackwidow/src/options_helper.h:47:1: error: could not convert ‘{{"max_background_jobs", {208, blackwidow::MemberType::kInt}}, {"max_background_compactions", {212, blackwidow::MemberType::kInt}}, {"base_background_compactions", {<expression error>, blackwidow::MemberType::kInt}}, {"max_open_files", {68, blackwidow::MemberType::kInt}}, {"bytes_per_sync", {400, blackwidow::MemberType::kUint64T}}, {"delayed_write_rate", {456, blackwidow::MemberType::kUint64T}}, {"max_total_wal_size", {80, blackwidow::MemberType::kUint64T}}, {"wal_bytes_per_sync", {408, blackwidow::MemberType::kUint64T}}, {"stats_dump_period_sec", {304, blackwidow::MemberType::kUint}}}’ from ‘<brace-enclosed initializer list>’ to ‘std::unordered_map<std::__cxx11::basic_string<char>, blackwidow::MemberTypeInfo>’
[build]    47 | };
[build]       | ^
[build]       | |
[build]       | <brace-enclosed initializer list>

base_background_compactions has been removed
link

@kernelai
Copy link
Collaborator Author

kernelai commented Dec 3, 2022

errror:

build] /home/kernelai/github.com/pika/src/blackwidow/../../third/rocksdb/util/core_local.h:66:15: error: ‘port’ has not been declared
[build]    66 |   int cpuid = port::PhysicalCoreID();

this is because bw/db_checkpoint.cc use CopyFile function which in rocksdb/file/file_util.cc。it cant find name port which is configed posix version.
so, add add_definitions(-DROCKSDB_PLATFORM_POSIX -DROCKSDB_LIB_IO_POSIX)in bw cmakelist

@wanghenshui wanghenshui mentioned this issue Dec 13, 2022
78 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants