Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

使用pika出现不支持hello命令 #1241

Closed
LangYuanzh opened this issue Jan 16, 2023 · 4 comments
Closed

使用pika出现不支持hello命令 #1241

LangYuanzh opened this issue Jan 16, 2023 · 4 comments
Assignees
Labels
redis API redis API compatibility

Comments

@LangYuanzh
Copy link

使用 较新版本的lettuce数据源会用到hello命令,pika最新版本目前不支持

@kernelai
Copy link
Collaborator

kernelai commented Jan 16, 2023

解释:hello命令为了切换协议,目前pika还不支持resp3 。这个会加入到今年的开发计划中。
目标:支持redis6 hello 命令。
临时方案:pika是否可以返回hello命令的部分结果,但是不支持协议切换。从而做到客户端兼容?
你可以协助我们做一些调研吗?加入到pika的开发中。

@kernelai kernelai added the redis API redis API compatibility label Jan 16, 2023
@kernelai
Copy link
Collaborator

kernelai commented Jan 16, 2023

后续pika的命令解析可以直接用hiredis,降低开发成本,提高兼容度。

@kernelai kernelai assigned kernelai and unassigned kernelai Jan 16, 2023
@weedge
Copy link
Contributor

weedge commented Jan 16, 2023

pls assign to me

@weedge
Copy link
Contributor

weedge commented Feb 1, 2023

refer to redis hello commits:

  1. impl hello cmd: redis/redis@4f0860c
  2. add SETNAME option for HELLO: redis/redis@21f92e9
  3. impl CLIENT SETNAME cmd: redis/redis@6272ca6

kvrocks support hello cmd commit(don't support RESP3 protocol,see this issue: apache/kvrocks#753): apache/kvrocks@231f750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis API redis API compatibility
Projects
None yet
Development

No branches or pull requests

3 participants