Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: support seek perfomence #1291

Closed
wanghenshui opened this issue Feb 21, 2023 · 7 comments
Closed

rocksdb: support seek perfomence #1291

wanghenshui opened this issue Feb 21, 2023 · 7 comments
Assignees
@WyattJia
Labels
enhancement rocksdb

Comments

@wanghenshui
Copy link
Collaborator

No description provided.

This was referenced Feb 21, 2023
Closed
Closed
@wanghenshui
Copy link
Collaborator Author

Qihoo360/blackwidow#17

@WyattJia
Copy link
Contributor

WyattJia commented Mar 7, 2023

是不是把我之前的 patch 搬过来，然后补充下 benchmark

@kernelai
Copy link
Collaborator

kernelai commented Mar 7, 2023

是不是把我之前的 patch 搬过来，然后补充下 benchmark

approve

@WyattJia
Copy link
Contributor

WyattJia commented Mar 7, 2023

是不是把我之前的 patch 搬过来，然后补充下 benchmark

approve

assgin to me

@AlexStocks
Copy link
Collaborator

AlexStocks commented Feb 8, 2024 •
edited
Loading

相应 PR Qihoo360/blackwidow#17 在 seek 的时候指定 iterator range 上下边界，但有问题：

image

里面 list RedisLists::LRem 函数这个地方，read_options 这里他设置值了，但是 "rocksdb::Iterator* iter = db_->NewIterator(default_read_options_, handles_[1]); " 这里使用的还是 default_read_options_

另外，这个 PR 已经 2022 年合并了，但是 Pika 仓库 src/storage 里面 Blackwidow 最新的代码里没这个 PR 的代码，很神奇

@WyattJia
Copy link
Contributor

reassgin to me

@AlexStocks
Copy link
Collaborator

reassgin to me

thank you.

@QlQlqiqi QlQlqiqi mentioned this issue May 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WyattJia WyattJia

Labels
enhancement rocksdb
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kernelai @AlexStocks @WyattJia @wanghenshui @yaoyinnan