Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support PGO #1300

Closed
wanghenshui opened this issue Feb 22, 2023 · 4 comments
Closed

build: support PGO #1300

wanghenshui opened this issue Feb 22, 2023 · 4 comments
Assignees

Comments

@wanghenshui
Copy link
Collaborator

No description provided.

@wanghenshui wanghenshui mentioned this issue Feb 22, 2023
78 tasks
@AlexStocks
Copy link
Collaborator

恨水:编译选项,在编译阶段生成 profile,然后进行调优。

@zamazan4ik
Copy link

zamazan4ik commented Aug 30, 2023

@wanghenshui @AlexStocks what is the status of this task? I didn't find related to PGO changes in Pika.

Recently I did many PGO benchmarks on multiple projects - the results are available here. I think the most interesting results for you will be PGO results on different databases (including Redis, Memcached, DragonflyDB, and many others) - link.

We need to evaluate PGO's applicability to Pika. And if it helps to achieve better performance - add a note to the documentation about that. In this case, users and maintainers will be aware of another optimization opportunity for Pika. Also, PGO integration into the build scripts can help users and maintainers easily apply PGO for their own workloads.

After PGO, I can suggest evaluating LLVM BOLT as an additional optimization step after PGO.

If you already tested PGO on Pika - could you please share the current status with the performance results?

Thanks in advance!

@wanghenshui
Copy link
Collaborator Author

@wanghenshui @AlexStocks what is the status of this task? I didn't find related to PGO changes in Pika.

Recently I did many PGO benchmarks on multiple projects - the results are available here. I think the most interesting results for you will be PGO results on different databases (including Redis, Memcached, DragonflyDB, and many others) - link.

We need to evaluate PGO's applicability to Pika. And if it helps to achieve better performance - add a note to the documentation about that. In this case, users and maintainers will be aware of another optimization opportunity for Pika. Also, PGO integration into the build scripts can help users and maintainers easily apply PGO for their own workloads.

After PGO, I can suggest evaluating LLVM BOLT as an additional optimization step after PGO.

If you already tested PGO on Pika - could you please share the current status with the performance results?

Thanks in advance!

sorry, current we focus on server stable and dev-ops building, PGO is move to next year, when server is robustness enough

@AlexStocks
Copy link
Collaborator

AlexStocks commented Aug 30, 2023

@zamazan4ik If you have some suggestions, you can left them here.

If you would like to add PGO for PIKA and submit your PR, our community appreciate your great work.

First of all, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants