Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] BLS leaks API key to the logs if the key was not validated #6662

Closed
piiq opened this issue Sep 9, 2024 · 2 comments · Fixed by #6665
Closed

[Bug] BLS leaks API key to the logs if the key was not validated #6662

piiq opened this issue Sep 9, 2024 · 2 comments · Fixed by #6665
Assignees
@deeleeramone

Comments

@piiq
Copy link
Contributor

piiq commented Sep 9, 2024

The error message that is displayed if an API request is make with a key that hasn't yet been validated displays the key itself.

image

It's better for us to sanitize the error message to prevent api keys from leaking into logs
@deeleeramone
Copy link
Contributor

I was under the impression we were already sanitizing logs, but I will investigate. Thanks!

@deeleeramone deeleeramone self-assigned this Sep 10, 2024
@deeleeramone deeleeramone mentioned this issue Sep 10, 2024
Merged
@piiq
Copy link
Contributor Author

piiq commented Sep 10, 2024

resolved by #6665

@piiq piiq closed this as completed Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeleeramone deeleeramone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BugFix] Fix BLS Error and API Exception Handling - Resolves #6661 and #6662 OpenBB-finance/OpenBB
2 participants
@piiq @deeleeramone