Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web UI localisation #400

Closed
KipK opened this issue Jul 30, 2022 · 5 comments
Closed

web UI localisation #400

KipK opened this issue Jul 30, 2022 · 5 comments

Comments

@KipK
Copy link
Collaborator

KipK commented Jul 30, 2022

I have started to add localisation to the web UI ( english / french), using i18next-ko npm.

The WIP branches are here:

https://github.com/KipK/ESP32_WiFi_V4.x/tree/localisation
https://github.com/KipK/openevse_wifi_gui/tree/i18next-ko

If you have any suggestions while I'm on it.
Works well for now, but boring to complete :)

Got to say, this knockout.js is a pain compared to modern fw.

@KipK
Copy link
Collaborator Author

KipK commented Jul 31, 2022

It's mostly ready. As it's based on Current Shaper branch, I will pull request this after the shaper merge.
evse_loc1
evse_loc2

@jeremypoulter
Copy link
Collaborator

Great work, this is something that has been missing for a while now, hopefully we get some more contributions for other languages now too.

Knockout.js is a means to an end, and a vast implement over what we had before ;-). Ultimately we need to rebuild the UI using more modern tools, probably based on Material UI.

@KipK
Copy link
Collaborator Author

KipK commented Aug 1, 2022

I'd vote for a Svelte.js or Preact js fw with any light CSS fw like Purecss or Skeleton.
Material is a bit heavy but I think we can limitate that with tree-shaking.

Also first, UX should be revisited a bit, actual thing looks more like a patchwork of additions :)

@jeremypoulter
Copy link
Collaborator

Indeed the current UI is a patchwork of stuff that has evolved over the lifetime of the project. I have created #401 to track the requirements/ideas for the new UI.

@jeremypoulter
Copy link
Collaborator

Fixed via #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants