Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend CLI openfn pull command to the allow snapshot id via argument #730

Closed
christad92 opened this issue Jul 9, 2024 · 1 comment
Closed
Assignees

Comments

@christad92
Copy link

GitHub actions rely on opening pull to fetch project state and .yaml files from the app to a GitHub repository (as it would when called in a local environment). When this command is called, the latest version of the project (workflows and settings) is fetched and saved in a directory specified in the config.json file.

Whilst this works for most use cases, there's a challenge when openfn pull is triggered by the Sync to GitHub feature on Lightning. This is because there is a lag between when the Sync to GitHub event was triggered and when the GitHub action triggers the openfn pull command. With snapshots, we want to be able to attach a snapshot id to openfn pull so that newer changes are not deployed until the user syncs them by clicking "Sync to GitHub".

@christad92
Copy link
Author

Merged with the #729 as a duplicate.

@christad92 christad92 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants