Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Murmur3 is incompatible with C++ reference implementation for negative seed values #68

Open
oertl opened this issue Oct 23, 2021 · 2 comments
Open

Murmur3 is incompatible with C++ reference implementation for negative seed values #68

oertl opened this issue Oct 23, 2021 · 2 comments
Assignees
@rogersimmons
Labels
review

Comments

@oertl
Copy link

oertl commented Oct 23, 2021

It seems that the Murmur3 implementation has the same problem as that in Guava (see google/guava#3493).
@gzm55
Copy link
Collaborator

gzm55 commented Oct 25, 2021

@oertl now the negative seeds can pass ut with the latest guava (31.0.1-jre). The implementation of this project decides to keep compatible with the upstream guava version, and we should have to wait the decision from google/guava#3493.

@oertl
Copy link
Author

oertl commented Nov 10, 2021

The same bug also existed in Apache Commons Codec where it was fixed in version 1.14, see https://issues.apache.org/jira/browse/CODEC-264.

@tgd tgd added the review label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogersimmons rogersimmons

Labels
review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tgd @gzm55 @oertl @rogersimmons