Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add register api with dao cmd. #73

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

IRONICBo
Copy link
Collaborator

@IRONICBo IRONICBo commented Jul 7, 2023

🔍 What type of PR is this?

/kind feature

👀 What this PR does / why we need it:

  1. Add dal and dao generation.
  2. Add user models.
  3. Add register api.

🅰 Which issue(s) this PR fixes:

Fixes #72

📝 Special notes for your reviewer:

We need to use dal and dao to generate code first and append new function in generated files.

@IRONICBo IRONICBo self-assigned this Jul 7, 2023
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 7, 2023
@pull-request-size
Copy link

🤖 Whoa! Easy there, Partner!

This PR is too big. It's over 1000. Please break it up into smaller PRs.

@IRONICBo IRONICBo temporarily deployed to openkf July 7, 2023 05:17 — with GitHub Actions Inactive
Signed-off-by: IRONICBo <[email protected]>
@IRONICBo IRONICBo temporarily deployed to openkf July 7, 2023 05:22 — with GitHub Actions Inactive
@IRONICBo IRONICBo enabled auto-merge July 7, 2023 06:31
Copy link
Contributor

@cubxxw cubxxw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cubxxw cubxxw disabled auto-merge July 7, 2023 07:32
@cubxxw cubxxw merged commit d4a6370 into openimsdk:main Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add register api.
2 participants