From d7b16572d88bf29342873f732ac5613ff3961024 Mon Sep 17 00:00:00 2001 From: Joshua Kreuder Date: Fri, 8 Mar 2024 12:33:16 +0100 Subject: [PATCH] =?UTF-8?q?Revert=20"=F0=9F=8F=97=EF=B8=8F=20No=20DB=20Aut?= =?UTF-8?q?ocommit=20before=20closing=20the=20DB=20Connection.=20Commit=20?= =?UTF-8?q?now=20Explicitally"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 94c74428179a4217019c47cf02461a8ab3f182d5. --- src/godoo_cli/commands/db/connection.py | 2 ++ src/godoo_cli/commands/db/passwords.py | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/godoo_cli/commands/db/connection.py b/src/godoo_cli/commands/db/connection.py index ca1772c..8b8dd8b 100644 --- a/src/godoo_cli/commands/db/connection.py +++ b/src/godoo_cli/commands/db/connection.py @@ -69,6 +69,8 @@ def connect(self): cr = connection.cursor() try: yield cr + LOGGER.debug("Committing DB cursor") + connection.commit() except Exception as e: LOGGER.warning("Rolling Back DB cursor. Got Exception: %s", e) connection.rollback() diff --git a/src/godoo_cli/commands/db/passwords.py b/src/godoo_cli/commands/db/passwords.py index 87c0483..b5819f8 100644 --- a/src/godoo_cli/commands/db/passwords.py +++ b/src/godoo_cli/commands/db/passwords.py @@ -51,7 +51,6 @@ def set_passwords( with connection.connect() as conn: try: conn.execute(f"UPDATE res_users SET password='{hashed_pw}'") - conn.commit() except Exception: raise typer.Exit(1) LOGGER.info("Password for all users set to: '%s'", new_password)