Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Certain 2ld files crash in the Layout Viewer, but it's inconsistent #53

Closed
Rikux3 opened this issue Dec 8, 2019 · 3 comments · Fixed by #79
Closed

Certain 2ld files crash in the Layout Viewer, but it's inconsistent #53

Rikux3 opened this issue Dec 8, 2019 · 3 comments · Fixed by #79
Labels
Bug Something is not working as intended, or at all. Novice Issue An easy to solve issue, good for newcomers.

Comments

@Rikux3
Copy link
Contributor

Rikux3 commented Dec 8, 2019

Error in Xe.Drawing.Direct3D/Drawing.Surface.cs, Line 155.
Texture.Description is null, so accessing Width causes an NullReferenceException.

First open event/layout/jp/tt_khend.2ld and then event/layout/jp/lm_204s_2.2ld to reproduce.

2019-12-08 15_28_35-Window
@Xeeynamo
Copy link
Contributor

Xeeynamo commented Dec 9, 2019

Thanks for opening the issue. This is definitively a bug. I will have a look on that file ASAP!

@Xeeynamo Xeeynamo added Bug Something is not working as intended, or at all. Novice Issue An easy to solve issue, good for newcomers. labels Dec 9, 2019
@Xeeynamo Xeeynamo mentioned this issue Feb 10, 2020
Merged
@Xeeynamo
Copy link
Contributor

Fixed in #79. I am requesting you as a reviewer to double-check if everything is all right!

@Rikux3 Rikux3 closed this as completed Feb 12, 2020
@Rikux3
Copy link
Contributor Author

Rikux3 commented Feb 12, 2020 •
edited
Loading

Indeed fixed with #79

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something is not working as intended, or at all. Novice Issue An easy to solve issue, good for newcomers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix LayoutViewer bug OpenKH/OpenKh
2 participants
@Xeeynamo @Rikux3