After running devc (start in container) the Run/Debug config history is messed up

[scottkurz]

If you do the sequence (run or debug).

1. start
2. custom start .. (non-container)
3. start in container
4. start

In step 4., we should reuse the config in step 2., but we don't.

[scottkurz]

OK..the problem is the last line here in LaunchConfigurationHelper:

    public ILaunchConfiguration getLaunchConfiguration(IProject iProject, String mode, RuntimeEnv runtimeEnv) throws Exception {
        DevModeOperations devModeOps = DevModeOperations.getInstance();
        ILaunchConfiguration configuration = null;
        ILaunchManager iLaunchMgr = DebugPlugin.getDefault().getLaunchManager();
        ILaunchConfigurationType iLaunchConfigType = iLaunchMgr
                .getLaunchConfigurationType(LaunchConfigurationDelegateLauncher.LAUNCH_CONFIG_TYPE_ID);

        // Find the set of configurations that were used by the currently active project last.
        ILaunchConfiguration[] existingConfigs = iLaunchMgr.getLaunchConfigurations(iLaunchConfigType);

        List<ILaunchConfiguration> matchingConfigList = filterLaunchConfigurations(existingConfigs, iProject.getName(), runtimeEnv);

        switch (matchingConfigList.size()) {
            case 0:
                // Create a new configuration.
                String newName = iLaunchMgr.generateLaunchConfigurationName(iProject.getName());
                ILaunchConfigurationWorkingCopy workingCopy = iLaunchConfigType.newInstance(null, newName);
                workingCopy.setAttribute(StartTab.PROJECT_NAME, iProject.getName());
                workingCopy.setAttribute(StartTab.PROJECT_START_PARM, devModeOps.getProjectModel().getDefaultStartParameters(iProject));
                workingCopy.setAttribute(StartTab.PROJECT_RUN_IN_CONTAINER, false);

It shouldn't set that last attribute to 'false', but rather should use the value from the current request (is it a dev or a devc?).

TESTS

We should also look at our tests to understand why this wasn't caught.