Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Birkhoff transcription interface to be more consistent with others. #1090

Closed
robfalck opened this issue Jul 30, 2024 · 0 comments · Fixed by #1088
Closed

Change Birkhoff transcription interface to be more consistent with others. #1090

robfalck opened this issue Jul 30, 2024 · 0 comments · Fixed by #1088
Assignees

Comments

@robfalck
Copy link
Contributor

Proposed feature.

The Birkhoff transcription currently accepts a BirkhoffGrid option specifying its grid data. This is redundant since Birkhoff should only use BirkhoffGrid and never one of the other grid types.

This change will make it so that Birkhoff takes in num_nodes and grid_type and instantiates the grid internally.

Since Birkhoff hasn't been officially released and documented with dymos yet, we will not be preserving the previous behavior.

Example

N./A

@robfalck robfalck self-assigned this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant