diff --git a/.github/phpstan-baseline.neon b/.github/phpstan-baseline.neon index 822de5e2efe..a09c2cbf013 100644 --- a/.github/phpstan-baseline.neon +++ b/.github/phpstan-baseline.neon @@ -125,26 +125,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Gallery.php - - - message: "#^Method Mage_Adminhtml_Block_Catalog_Product_Helper_Form_Price\\:\\:getEscapedValue\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php - - message: "#^PHPDoc type Mage_Core_Model_Abstract of property Mage_Adminhtml_Block_Customer_Edit_Renderer_Region\\:\\:\\$_factory is not covariant with PHPDoc type Mage_Core_Model_Factory of overridden property Mage_Core_Block_Abstract\\:\\:\\$_factory\\.$#" count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Renderer/Region.php - - - message: "#^Method Mage_Adminhtml_Block_Customer_Edit_Tab_Newsletter_Grid_Filter_Status\\:\\:getCondition\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Newsletter/Grid/Filter/Status.php - - - - message: "#^Method Mage_Adminhtml_Block_Customer_Edit_Tab_View\\:\\:getCreateDate\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php - - message: "#^Property Mage_Adminhtml_Block_Customer_Edit_Tab_View_Sales\\:\\:\\$_collection \\(Mage_Sales_Model_Entity_Sale_Collection\\) does not accept Varien_Data_Collection_Db\\.$#" count: 1 @@ -155,21 +140,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View/Wishlist.php - - - message: "#^Method Mage_Adminhtml_Block_Customer_Form_Element_File\\:\\:getEscapedValue\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - - - message: "#^Parameter \\#1 \\$index \\(int\\) of method Mage_Adminhtml_Block_Customer_Form_Element_File\\:\\:getEscapedValue\\(\\) should be compatible with parameter \\$index \\(string\\|null\\) of method Varien_Data_Form_Element_Abstract\\:\\:getEscapedValue\\(\\)$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php - - - - message: "#^Method Mage_Adminhtml_Block_Customer_Form_Element_Image\\:\\:_getPreviewUrl\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/Image.php - - message: "#^Method Mage_Adminhtml_Block_Customer_Sales_Order_Address_Form_Renderer_Vat\\:\\:getValidateButton\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\.$#" count: 1 @@ -200,11 +170,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Dashboard/Graph.php - - - message: "#^Method Mage_Adminhtml_Block_Newsletter_Subscriber_Grid_Filter_Website\\:\\:getCondition\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php - - message: "#^Variable \\$class might not be defined\\.$#" count: 1 @@ -316,8 +281,8 @@ parameters: path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid.php - - message: "#^Method Mage_Adminhtml_Block_Review_Grid_Filter_Type\\:\\:getCondition\\(\\) should return array but returns int\\.$#" - count: 3 + message: "#^Return type \\(int\\) of method Mage_Adminhtml_Block_Review_Grid_Filter_Type\\:\\:getCondition\\(\\) should be compatible with return type \\(array\\|null\\) of method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select\\:\\:getCondition\\(\\)$#" + count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php - @@ -325,21 +290,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Review/Product/Grid.php - - - message: "#^Method Mage_Adminhtml_Block_Sales_Creditmemo_Grid\\:\\:getRowUrl\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Creditmemo/Grid.php - - - - message: "#^Method Mage_Adminhtml_Block_Sales_Invoice_Grid\\:\\:getRowUrl\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Invoice/Grid.php - - - - message: "#^Method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getColumnRenderer\\(\\) should return Mage_Core_Block_Abstract but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Billing_Address\\:\\:getAddress\\(\\) should return Mage_Customer_Model_Address but returns Mage_Sales_Model_Quote_Address\\.$#" count: 1 @@ -385,11 +335,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar.php - - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Create_Sidebar_Abstract\\:\\:canDisplay\\(\\) should return bool but returns int\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Abstract.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\:\\:useProductItem\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -420,11 +365,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Creditmemo/View/Items.php - - - message: "#^Method Mage_Adminhtml_Block_Sales_Order_Grid\\:\\:getRowUrl\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php - - message: "#^Return type \\(Mage_Sales_Model_Order_Shipment\\) of method Mage_Adminhtml_Block_Sales_Order_Shipment_Create_Items\\:\\:getSource\\(\\) should be compatible with return type \\(Mage_Sales_Model_Order_Invoice\\) of method Mage_Adminhtml_Block_Sales_Items_Abstract\\:\\:getSource\\(\\)$#" count: 1 @@ -510,11 +450,6 @@ parameters: count: 2 path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form.php - - - message: "#^Method Mage_Adminhtml_Block_System_Config_Form_Fieldset\\:\\:_getCollapseState\\(\\) should return bool but returns int\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php - - message: "#^Variable \\$attributes might not be defined\\.$#" count: 1 @@ -530,11 +465,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/System/Convert/Profile/Run.php - - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getEditMode\\(\\) should return bool but returns int\\|string\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Edit\\:\\:getUsedCurrentlyForPaths\\(\\) should return string but returns array\\.$#" count: 1 @@ -545,11 +475,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php - - - message: "#^Method Mage_Adminhtml_Block_System_Email_Template_Grid_Filter_Type\\:\\:getCondition\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Email/Template/Grid/Filter/Type.php - - message: "#^Method Mage_Core_Model_Email_Template\\:\\:getProcessedTemplate\\(\\) invoked with 2 parameters, 0\\-1 required\\.$#" count: 1 @@ -610,16 +535,6 @@ parameters: count: 15 path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Edit/Form.php - - - message: "#^Method Mage_Adminhtml_Block_System_Store_Grid_Render_Group\\:\\:render\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php - - - - message: "#^Method Mage_Adminhtml_Block_System_Store_Grid_Render_Store\\:\\:render\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php - - message: "#^Call to an undefined method Mage_Tag_Model_Resource_Tag_Collection\\:\\:addAttributeToFilter\\(\\)\\.$#" count: 1 @@ -630,21 +545,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Tax/Rate/Grid/Renderer/Data.php - - - message: "#^Method Mage_Adminhtml_Block_Urlrewrite_Category_Tree\\:\\:getTreeArray\\(\\) should return array but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php - - message: "#^Variable \\$category in empty\\(\\) always exists and is not falsy\\.$#" count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Category/Tree.php - - - message: "#^Method Mage_Adminhtml_Block_Urlrewrite_Selector\\:\\:getSelectorLabel\\(\\) should return array but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Urlrewrite/Selector.php - - message: "#^Method Mage_Adminhtml_Block_Widget_Container\\:\\:_addButtonChildBlock\\(\\) should return Mage_Adminhtml_Block_Widget_Button but returns Mage_Core_Block_Abstract\\|false\\.$#" count: 1 @@ -685,26 +590,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Datetime.php - - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select\\:\\:getCondition\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php - - - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Country\\:\\:render\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Country.php - - message: "#^Binary operation \"\\*\" between string and 1 results in an error\\.$#" count: 1 path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Renderer/Number.php - - - message: "#^Method Mage_Adminhtml_Block_Widget_Grid_Serializer\\:\\:getColumnInputNames\\(\\) should return array but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Block/Widget/Grid/Serializer.php - - message: "#^Call to an undefined method Mage_Adminhtml_Block_Widget_Tab_Interface\\:\\:getSkipGenerateContent\\(\\)\\.$#" count: 1 @@ -760,11 +650,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Model/Giftmessage/Save.php - - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:_getQuoteItem\\(\\) should return Mage_Sales_Model_Quote_Item but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/Model/Sales/Order/Create.php - - message: "#^Method Mage_Adminhtml_Model_Sales_Order_Create\\:\\:initFromOrderItem\\(\\) should return Mage_Sales_Model_Quote_Item\\|string but returns \\$this\\(Mage_Adminhtml_Model_Sales_Order_Create\\)\\.$#" count: 2 @@ -835,11 +720,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/Model/System/Store.php - - - message: "#^Method Mage_Adminhtml_Catalog_CategoryController\\:\\:_initCategory\\(\\) should return Mage_Catalog_Model_Category but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Catalog/CategoryController.php - - message: "#^Argument of an invalid type string supplied for foreach, only iterables are supported\\.$#" count: 1 @@ -890,11 +770,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Adminhtml/controllers/Permissions/VariableController.php - - - message: "#^Method Mage_Adminhtml_Promo_WidgetController\\:\\:_initCategory\\(\\) should return Mage_Catalog_Model_Category but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Adminhtml/controllers/Promo/WidgetController.php - - message: "#^Cannot call method aggregate\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 2 @@ -1170,11 +1045,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/ResourcePermission.php - - - message: "#^Method Mage_Api2_Model_Acl_Global_Rule_Tree\\:\\:_getTreeNode\\(\\) should return array but returns null\\.$#" - count: 3 - path: ../app/code/core/Mage/Api2/Model/Acl/Global/Rule/Tree.php - - message: "#^Variable \\$operationName might not be defined\\.$#" count: 2 @@ -1275,11 +1145,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Api2/Model/Route/ApiType.php - - - message: "#^Method Mage_Authorizenet_Block_Directpost_Form\\:\\:_toHtml\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Authorizenet/Block/Directpost/Form.php - - message: "#^Call to an undefined method Varien_Object\\:\\:decrypt\\(\\)\\.$#" count: 1 @@ -1350,11 +1215,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Backup/Model/Resource/Db.php - - - message: "#^Method Mage_Backup_Model_Resource_Helper_Mysql4\\:\\:getTableCreateSql\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Backup/Model/Resource/Helper/Mysql4.php - - message: "#^Parameter \\#1 \\$elementId \\(string\\) of method Mage_Bundle_Block_Adminhtml_Catalog_Product_Composite_Fieldset_Options_Type_Checkbox\\:\\:setValidationContainer\\(\\) should be compatible with parameter \\$elementId \\(int\\) of method Mage_Bundle_Block_Catalog_Product_View_Type_Bundle_Option\\:\\:setValidationContainer\\(\\)$#" count: 1 @@ -1460,11 +1320,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Bundle/Model/Price/Index.php - - - message: "#^Method Mage_Bundle_Model_Product_Attribute_Source_Price_View\\:\\:getOptionText\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Bundle/Model/Product/Attribute/Source/Price/View.php - - message: "#^Call to an undefined method Mage_Bundle_Model_Product_Price\\:\\:getPricesTierPrice\\(\\)\\.$#" count: 2 @@ -1680,11 +1535,6 @@ parameters: count: 2 path: ../app/code/core/Mage/Catalog/Block/Product/New.php - - - message: "#^Method Mage_Catalog_Block_Product_View_Media\\:\\:getGalleryImageUrl\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Block/Product/View/Media.php - - message: "#^Method Mage_Catalog_Block_Product_View_Options_Type_Date\\:\\:_getValueWithLeadingZeros\\(\\) should return string but returns int\\.$#" count: 1 @@ -1800,11 +1650,6 @@ parameters: count: 3 path: ../app/code/core/Mage/Catalog/Helper/Product.php - - - message: "#^Method Mage_Catalog_Helper_Product\\:\\:getProductUrl\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Helper/Product.php - - message: "#^Property Mage_Catalog_Helper_Product_Compare\\:\\:\\$_itemCollection \\(Mage_Catalog_Model_Resource_Eav_Mysql4_Product_Compare_Item_Collection\\) does not accept Mage_Catalog_Model_Resource_Product_Compare_Item_Collection\\.$#" count: 1 @@ -1955,11 +1800,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - - message: "#^Method Mage_Catalog_Model_Convert_Parser_Product\\:\\:getProductTypeId\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Convert/Parser/Product.php - - message: "#^Method Mage_Catalog_Model_Category\\:\\:getParentDesignCategory\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -2045,11 +1885,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Catalog/Model/Product.php - - - message: "#^Method Mage_Catalog_Model_Product\\:\\:getCategoryId\\(\\) should return int but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product.php - - message: "#^Method Mage_Catalog_Model_Product\\:\\:getDefaultAttributeSetId\\(\\) should return int but returns string\\|null\\.$#" count: 1 @@ -2110,16 +1945,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Media/Api/V2.php - - - message: "#^Method Mage_Catalog_Model_Product_Attribute_Tierprice_Api\\:\\:prepareTierPrices\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api.php - - - - message: "#^Method Mage_Catalog_Model_Product_Attribute_Tierprice_Api_V2\\:\\:prepareTierPrices\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Attribute/Tierprice/Api/V2.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Compare_Item\\:\\:clean\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -2200,11 +2025,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Catalog/Model/Product/Type/Configurable/Price.php - - - message: "#^Method Mage_Catalog_Model_Product_Type_Price\\:\\:getFormatedTierPrice\\(\\) should return array\\|float but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Product/Type/Price.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Attribute_Abstract\\:\\:isScopeStore\\(\\)\\.$#" count: 2 @@ -2440,11 +2260,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Compare/Item.php - - - message: "#^Method Mage_Catalog_Model_Resource_Product_Flat\\:\\:getAttributeSortColumn\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Catalog/Model/Resource/Product/Flat.php - - message: "#^Method Mage_Catalog_Model_Resource_Product_Flat\\:\\:getTypeId\\(\\) should return int but returns string\\|null\\.$#" count: 1 @@ -2655,11 +2470,6 @@ parameters: count: 1 path: ../app/code/core/Mage/CatalogRule/Model/Rule.php - - - message: "#^Method Mage_CatalogSearch_Block_Advanced_Form\\:\\:getSearchableAttributes\\(\\) should return Varien_Data_Collection_Db but returns array\\.$#" - count: 1 - path: ../app/code/core/Mage/CatalogSearch/Block/Advanced/Form.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -2680,11 +2490,6 @@ parameters: count: 2 path: ../app/code/core/Mage/CatalogSearch/Block/Term.php - - - message: "#^Method Mage_CatalogSearch_Model_Advanced\\:\\:getAttributes\\(\\) should return array but returns Mage_Catalog_Model_Resource_Product_Attribute_Collection\\.$#" - count: 1 - path: ../app/code/core/Mage/CatalogSearch/Model/Advanced.php - - message: "#^Method Mage_CatalogSearch_Model_Advanced\\:\\:getProductCollection\\(\\) should return Mage_CatalogSearch_Model_Resource_Advanced_Collection but returns array\\|float\\|int\\|string\\|false\\|null\\.$#" count: 1 @@ -2710,11 +2515,6 @@ parameters: count: 1 path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Fulltext/Collection.php - - - message: "#^Method Mage_CatalogSearch_Model_Resource_Search_Collection\\:\\:_getSearchInOptionSql\\(\\) should return string but returns false\\.$#" - count: 2 - path: ../app/code/core/Mage/CatalogSearch/Model/Resource/Search/Collection.php - - message: "#^Cannot call method setItem\\(\\) on array\\.$#" count: 1 @@ -2770,21 +2570,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Checkout/Model/Cart/Api.php - - - message: "#^Method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php - - message: "#^Variable \\$customer might not be defined\\.$#" count: 4 path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api.php - - - message: "#^Method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should return array but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Checkout/Model/Cart/Customer/Api/V2.php - - message: "#^Parameter \\#1 \\$data \\(object\\) of method Mage_Checkout_Model_Cart_Customer_Api_V2\\:\\:_prepareCustomerAddressData\\(\\) should be compatible with parameter \\$data \\(array\\) of method Mage_Checkout_Model_Cart_Customer_Api\\:\\:_prepareCustomerAddressData\\(\\)$#" count: 1 @@ -2840,6 +2630,11 @@ parameters: count: 2 path: ../app/code/core/Mage/Checkout/Model/Type/Onepage.php + - + message: "#^Comparison operation \"\\=\\=\" between 0\\|0\\.0\\|array\\|string\\|false\\|null and 0 results in an error\\.$#" + count: 1 + path: ../app/code/core/Mage/Checkout/controllers/CartController.php + - message: "#^Call to an undefined method Mage_Sales_Model_Service_Order\\:\\:register\\(\\)\\.$#" count: 1 @@ -2860,11 +2655,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Cms/Model/Wysiwyg/Images/Storage.php - - - message: "#^Method Mage_ConfigurableSwatches_Helper_Productimg\\:\\:_resizeSwatchImage\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/ConfigurableSwatches/Helper/Productimg.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 2 parameters, 0 required\\.$#" count: 1 @@ -2905,11 +2695,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Block/Abstract.php - - - message: "#^Method Mage_Core_Block_Abstract\\:\\:getCacheLifetime\\(\\) should return int but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Block/Abstract.php - - message: "#^Method Mage_Core_Block_Abstract\\:\\:getHelper\\(\\) should return \\$this\\(Mage_Core_Block_Abstract\\) but returns Mage_Core_Block_Abstract\\.$#" count: 1 @@ -2930,11 +2715,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Controller/Front/Router.php - - - message: "#^Method Mage_Core_Controller_Request_Http\\:\\:getHttpHost\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Controller/Request/Http.php - - message: "#^Call to an undefined method Varien_Simplexml_Element\\:\\:is\\(\\)\\.$#" count: 1 @@ -3000,16 +2780,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Helper/Abstract.php - - - message: "#^Method Mage_Core_Helper_Http\\:\\:getRemoteAddr\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Helper/Http.php - - - - message: "#^Method Mage_Core_Helper_Http\\:\\:getServerAddr\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Helper/Http.php - - message: "#^Property Mage_Core_Helper_String\\:\\:\\$_arrayHelper \\(Mage_Core_Helper_Array\\) does not accept Mage_Core_Helper_Abstract\\.$#" count: 1 @@ -3080,11 +2850,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Model/Config.php - - - message: "#^Method Mage_Core_Model_Config\\:\\:getVarDir\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Config.php - - message: "#^Property Varien_Simplexml_Config\\:\\:\\$_cacheChecksum \\(unknown_type\\) does not accept null\\.$#" count: 1 @@ -3110,11 +2875,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Model/Config.php - - - message: "#^Method Mage_Core_Model_Config_Element\\:\\:getClassName\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Config/Element.php - - message: "#^Method Mage_Core_Model_Cookie\\:\\:getHttponly\\(\\) should return bool but returns null\\.$#" count: 1 @@ -3130,21 +2890,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Core/Model/Date.php - - - message: "#^Method Mage_Core_Model_Date\\:\\:gmtDate\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Date.php - - - - message: "#^Method Mage_Core_Model_Date\\:\\:gmtTimestamp\\(\\) should return int but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Date.php - - - - message: "#^Method Mage_Core_Model_Date\\:\\:gmtTimestamp\\(\\) should return int but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Core/Model/Date.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Design\\:\\:validate\\(\\)\\.$#" count: 1 @@ -3460,16 +3205,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Customer/Block/Form/Register.php - - - message: "#^Method Mage_Customer_Block_Form_Register\\:\\:getRegion\\(\\) should return int but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Customer/Block/Form/Register.php - - - - message: "#^Method Mage_Customer_Block_Form_Register\\:\\:getRegion\\(\\) should return int but returns true\\.$#" - count: 2 - path: ../app/code/core/Mage/Customer/Block/Form/Register.php - - message: "#^Return type \\(int\\) of method Mage_Customer_Block_Form_Register\\:\\:getCountryId\\(\\) should be compatible with return type \\(string\\) of method Mage_Directory_Block_Data\\:\\:getCountryId\\(\\)$#" count: 1 @@ -3515,11 +3250,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Customer/Model/Api2/Customer/Address.php - - - message: "#^Method Mage_Customer_Model_Api2_Customer_Rest_Customer_V1\\:\\:_retrieve\\(\\) should return array but return statement is missing\\.$#" - count: 1 - path: ../app/code/core/Mage/Customer/Model/Api2/Customer/Rest/Customer/V1.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -3655,11 +3385,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Dataflow/Model/Convert/Action/Abstract.php - - - message: "#^Method Mage_Dataflow_Model_Convert_Adapter_Io\\:\\:getResource\\(\\) should return Varien_Io_Abstract but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Dataflow/Model/Convert/Adapter/Io.php - - message: "#^Call to an undefined method Mage_Dataflow_Model_Convert_Container_Interface\\:\\:getName\\(\\)\\.$#" count: 2 @@ -3715,11 +3440,6 @@ parameters: count: 2 path: ../app/code/core/Mage/Dataflow/Model/Profile.php - - - message: "#^Method Mage_Directory_Helper_Data\\:\\:getCountriesWithStatesRequired\\(\\) should return array but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Directory/Helper/Data.php - - message: "#^Property Mage_Directory_Helper_Data\\:\\:\\$_countryCollection \\(Mage_Directory_Model_Resource_Country_Collection\\) does not accept Mage_Core_Model_Resource_Db_Collection_Abstract\\.$#" count: 1 @@ -3755,16 +3475,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Downloadable/Block/Adminhtml/Catalog/Product/Edit/Tab/Downloadable/Links.php - - - message: "#^Method Mage_Downloadable_Block_Catalog_Product_Samples\\:\\:getSamples\\(\\) should return array but returns Mage_Downloadable_Model_Resource_Sample_Collection\\.$#" - count: 1 - path: ../app/code/core/Mage/Downloadable/Block/Catalog/Product/Samples.php - - - - message: "#^Method Mage_Downloadable_Block_Customer_Products_List\\:\\:getRemainingDownloads\\(\\) should return string but returns \\(float\\|int\\)\\.$#" - count: 1 - path: ../app/code/core/Mage/Downloadable/Block/Customer/Products/List.php - - message: "#^Cannot call method streamRead\\(\\) on resource\\.$#" count: 1 @@ -3835,11 +3545,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Eav/Model/Attribute.php - - - message: "#^Method Mage_Eav_Model_Attribute_Data_Abstract\\:\\:_applyInputFilter\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/Abstract.php - - message: "#^Method Mage_Eav_Model_Attribute_Data_Abstract\\:\\:setRequestScope\\(\\) should return string but returns \\$this\\(Mage_Eav_Model_Attribute_Data_Abstract\\)\\.$#" count: 1 @@ -3860,11 +3565,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Eav/Model/Attribute/Data/File.php - - - message: "#^Method Mage_Eav_Model_Attribute_Data_File\\:\\:extractValue\\(\\) should return array\\|string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Attribute/Data/File.php - - message: "#^Call to an undefined method Mage_Core_Model_Resource_Abstract\\:\\:getDefaultAttributes\\(\\)\\.$#" count: 1 @@ -4015,16 +3715,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Abstract.php - - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Backend_Datetime\\:\\:formatDate\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Backend/Datetime.php - - - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Frontend_Abstract\\:\\:getInputRendererClass\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Frontend/Abstract.php - - message: "#^Variable \\$out in empty\\(\\) always exists and is not falsy\\.$#" count: 1 @@ -4035,11 +3725,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Group.php - - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Boolean\\:\\:getOptionText\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Attribute/Source/Boolean.php - - message: "#^Call to an undefined method Mage_Eav_Model_Entity_Collection_Abstract\\:\\:getStoreId\\(\\)\\.$#" count: 1 @@ -4095,16 +3780,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php - - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getAttributeId\\(\\) should return int but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php - - - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getAttributeTable\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php - - message: "#^Method Mage_Eav_Model_Entity_Setup\\:\\:getDefaultAttributeGroupId\\(\\) should return int but returns string\\.$#" count: 1 @@ -4120,16 +3795,6 @@ parameters: count: 2 path: ../app/code/core/Mage/Eav/Model/Entity/Setup.php - - - message: "#^Method Mage_Eav_Model_Entity_Type\\:\\:fetchNewIncrementId\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Type.php - - - - message: "#^Method Mage_Eav_Model_Entity_Type\\:\\:getValueTablePrefix\\(\\) should return string but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Eav/Model/Entity/Type.php - - message: "#^Method Mage_Eav_Model_Resource_Entity_Attribute\\:\\:_getMaxSortOrder\\(\\) should return int but returns string\\.$#" count: 1 @@ -4595,26 +4260,11 @@ parameters: count: 1 path: ../app/code/core/Mage/Log/Model/Aggregation.php - - - message: "#^Method Mage_Log_Model_Customer\\:\\:getLoginAtTimestamp\\(\\) should return int but returns null\\.$#" - count: 1 - path: ../app/code/core/Mage/Log/Model/Customer.php - - message: "#^Binary operation \"\\+\" between non\\-falsy\\-string and 1 results in an error\\.$#" count: 2 path: ../app/code/core/Mage/Log/Model/Resource/Log.php - - - message: "#^Method Mage_Media_Model_File_Image\\:\\:_getReadAdapter\\(\\) should return Varien_Db_Adapter_Interface but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Media/Model/File/Image.php - - - - message: "#^Method Mage_Media_Model_File_Image\\:\\:_getWriteAdapter\\(\\) should return Varien_Db_Adapter_Interface but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Media/Model/File/Image.php - - message: "#^Method Mage_Media_Model_File_Image\\:\\:getImage\\(\\) should return bool\\|resource but returns GdImage\\.$#" count: 1 @@ -4690,16 +4340,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Oauth/controllers/TokenController.php - - - message: "#^Method Mage_Page_Block_Html_Pager\\:\\:getNextJumpPage\\(\\) should return int but returns null\\.$#" - count: 2 - path: ../app/code/core/Mage/Page/Block/Html/Pager.php - - - - message: "#^Method Mage_Page_Block_Html_Pager\\:\\:getPreviousJumpPage\\(\\) should return int but returns null\\.$#" - count: 2 - path: ../app/code/core/Mage/Page/Block/Html/Pager.php - - message: "#^Variable \\$finish might not be defined\\.$#" count: 1 @@ -4720,11 +4360,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Form/Cc.php - - - message: "#^Method Mage_Paygate_Block_Authorizenet_Form_Cc\\:\\:getPartialAuthorizationConfirmationMessage\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paygate/Block/Authorizenet/Form/Cc.php - - message: "#^Property Mage_Payment_Block_Info\\:\\:\\$_paymentSpecificInformation \\(Varien_Object\\) does not accept null\\.$#" count: 1 @@ -4815,11 +4450,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Paypal/Block/Express/Review.php - - - message: "#^Method Mage_Paypal_Block_Express_Review\\:\\:getShippingAddress\\(\\) should return Mage_Sales_Model_Quote_Address but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Block/Express/Review.php - - message: "#^Return type \\(false\\) of method Mage_Paypal_Block_Hosted_Pro_Info\\:\\:getCcTypeName\\(\\) should be compatible with return type \\(string\\|null\\) of method Mage_Paypal_Block_Payment_Info\\:\\:getCcTypeName\\(\\)$#" count: 1 @@ -4870,11 +4500,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Paypal/Controller/Express/Abstract.php - - - message: "#^Method Mage_Paypal_Helper_Data\\:\\:getElementBackendConfig\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Helper/Data.php - - message: "#^Method Mage_Paypal_Model_Api_Abstract\\:\\:_exportLineItems\\(\\) should return bool but empty return statement found\\.$#" count: 2 @@ -4990,11 +4615,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Paypal/Model/Ipn.php - - - message: "#^Method Mage_Paypal_Model_Payflowlink\\:\\:_getOrderFromResponse\\(\\) should return Mage_Sales_Model_Order but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - message: "#^Return type \\(bool\\) of method Mage_Paypal_Model_Payflowlink\\:\\:validate\\(\\) should be compatible with return type \\(\\$this\\(Mage_Payment_Model_Method_Cc\\)\\) of method Mage_Payment_Model_Method_Cc\\:\\:validate\\(\\)$#" count: 1 @@ -5005,11 +4625,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Paypal/Model/Payflowlink.php - - - message: "#^Method Mage_Paypal_Model_Payflowpro\\:\\:cancel\\(\\) should return \\$this\\(Mage_Paypal_Model_Payflowpro\\) but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Paypal/Model/Payflowpro.php - - message: "#^Property Mage_Paypal_Model_Payflowpro\\:\\:\\$_centinelFieldMap \\(string\\) does not accept default value of type array\\\\.$#" count: 1 @@ -5785,11 +5400,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Sales/Model/Recurring/Profile.php - - - message: "#^Method Mage_Sales_Model_Resource_Order_Abstract\\:\\:getGridTable\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Sales/Model/Resource/Order/Abstract.php - - message: "#^Cannot call method updateOnRelatedRecordChanged\\(\\) on Mage_Core_Model_Resource_Db_Collection_Abstract\\|false\\.$#" count: 1 @@ -5935,16 +5545,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Shipping/Model/Carrier/Pickup.php - - - message: "#^Method Mage_Shipping_Model_Carrier_Tablerate\\:\\:collectRates\\(\\) should return bool\\|Mage_Core_Model_Abstract but returns Mage_Shipping_Model_Rate_Result\\.$#" - count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - - - message: "#^Method Mage_Shipping_Model_Carrier_Tablerate\\:\\:getCode\\(\\) should return array but returns string\\.$#" - count: 1 - path: ../app/code/core/Mage/Shipping/Model/Carrier/Tablerate.php - - message: "#^Method Mage_Shipping_Model_Carrier_Tablerate\\:\\:getRate\\(\\) should return Mage_Core_Model_Abstract but returns array\\|bool\\.$#" count: 1 @@ -6035,11 +5635,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Tag/Model/Resource/Customer/Collection.php - - - message: "#^Method Mage_Tag_Model_Resource_Tag\\:\\:loadByName\\(\\) should return array\\|false but return statement is missing\\.$#" - count: 1 - path: ../app/code/core/Mage/Tag/Model/Resource/Tag.php - - message: "#^Variable \\$result might not be defined\\.$#" count: 1 @@ -6085,11 +5680,6 @@ parameters: count: 1 path: ../app/code/core/Mage/Tax/Model/Calculation/Rate.php - - - message: "#^Method Mage_Tax_Model_Class_Source_Product\\:\\:getOptionText\\(\\) should return string but returns false\\.$#" - count: 1 - path: ../app/code/core/Mage/Tax/Model/Class/Source/Product.php - - message: "#^Method Mage_Tax_Model_Config_Notification\\:\\:_getConfig\\(\\) should return Mage_Core_Model_Config_Data but returns bool\\|Mage_Core_Model_Abstract\\.$#" count: 1 diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Grid/Filter/Inventory.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Grid/Filter/Inventory.php index 0817059a142..88ee3b871bc 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Grid/Filter/Inventory.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Edit/Tab/Super/Config/Grid/Filter/Inventory.php @@ -28,6 +28,9 @@ */ class Mage_Adminhtml_Block_Catalog_Product_Edit_Tab_Super_Config_Grid_Filter_Inventory extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select { + /** + * @return array + */ protected function _getOptions() { return [ diff --git a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php index da36b3f850a..4e11c9021bc 100644 --- a/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php +++ b/app/code/core/Mage/Adminhtml/Block/Catalog/Product/Helper/Form/Price.php @@ -28,12 +28,19 @@ */ class Mage_Adminhtml_Block_Catalog_Product_Helper_Form_Price extends Varien_Data_Form_Element_Text { + /** + * @param array $attributes + */ public function __construct($attributes= []) { parent::__construct($attributes); $this->addClass('validate-zero-or-greater'); } + /** + * @return string + * @throws Mage_Core_Model_Store_Exception + */ public function getAfterElementHtml() { $html = parent::getAfterElementHtml(); @@ -61,6 +68,10 @@ public function getAfterElementHtml() return $html; } + /** + * @param $attribute + * @return string + */ protected function _getTaxObservingCode($attribute) { $spanId = "dynamic-tax-{$attribute->getAttributeCode()}"; @@ -68,6 +79,10 @@ protected function _getTaxObservingCode($attribute) return ""; } + /** + * @param null $index + * @return string|null + */ public function getEscapedValue($index=null) { $value = $this->getValue(); diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Newsletter/Grid/Filter/Status.php b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Newsletter/Grid/Filter/Status.php index ac21a18db80..8d0fcd2998e 100644 --- a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Newsletter/Grid/Filter/Status.php +++ b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/Newsletter/Grid/Filter/Status.php @@ -43,6 +43,9 @@ public function __construct() parent::__construct(); } + /** + * @return array + */ protected function _getOptions() { $result = []; @@ -53,9 +56,12 @@ protected function _getOptions() return $result; } + /** + * @return array|null + */ public function getCondition() { - if(is_null($this->getValue())) { + if (is_null($this->getValue())) { return null; } diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php index 9ce5bbff02c..2d122dae673 100644 --- a/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php +++ b/app/code/core/Mage/Adminhtml/Block/Customer/Edit/Tab/View.php @@ -26,14 +26,18 @@ * @package Mage_Adminhtml * @author Magento Core Team */ -class Mage_Adminhtml_Block_Customer_Edit_Tab_View - extends Mage_Adminhtml_Block_Template - implements Mage_Adminhtml_Block_Widget_Tab_Interface +class Mage_Adminhtml_Block_Customer_Edit_Tab_View extends Mage_Adminhtml_Block_Template implements Mage_Adminhtml_Block_Widget_Tab_Interface { + /** + * @var Mage_Customer_Model_Customer + */ protected $_customer; protected $_customerLog; + /** + * @return Mage_Customer_Model_Customer + */ public function getCustomer() { if (!$this->_customer) { @@ -42,6 +46,9 @@ public function getCustomer() return $this->_customer; } + /** + * @return string|void + */ public function getGroupName() { if ($groupId = $this->getCustomer()->getGroupId()) { @@ -68,20 +75,26 @@ public function getCustomerLog() /** * Get customer creation date * - * @return string + * @return string|null */ public function getCreateDate() { - if ( ! $this->getCustomer()->getCreatedAt()) { + if (! $this->getCustomer()->getCreatedAt()) { return null; } - return $this->_getCoreHelper()->formatDate($this->getCustomer()->getCreatedAt(), - Mage_Core_Model_Locale::FORMAT_TYPE_MEDIUM, true); + return $this->_getCoreHelper()->formatDate( + $this->getCustomer()->getCreatedAt(), + Mage_Core_Model_Locale::FORMAT_TYPE_MEDIUM, + true + ); } + /** + * @return string|null + */ public function getStoreCreateDate() { - if ( ! $this->getCustomer()->getCreatedAt()) { + if (! $this->getCustomer()->getCreatedAt()) { return null; } $date = Mage::app()->getLocale()->storeDate( @@ -112,6 +125,9 @@ public function getLastLoginDate() return Mage::helper('customer')->__('Never'); } + /** + * @return string + */ public function getStoreLastLoginDate() { if ($date = $this->getCustomerLog()->getLoginAtTimestamp()) { @@ -131,6 +147,9 @@ public function getStoreLastLoginDateTimezone() ->getConfig(Mage_Core_Model_Locale::XML_PATH_DEFAULT_TIMEZONE); } + /** + * @return string + */ public function getCurrentStatus() { $log = $this->getCustomerLog(); @@ -142,6 +161,9 @@ public function getCurrentStatus() return Mage::helper('customer')->__('Online'); } + /** + * @return string + */ public function getIsConfirmedStatus() { $this->getCustomer(); @@ -164,38 +186,55 @@ public function getStoreId() return $this->getCustomer()->getStoreId(); } + /** + * @return string + */ public function getBillingAddressHtml() { $html = ''; if ($address = $this->getCustomer()->getPrimaryBillingAddress()) { $html = $address->format('html'); - } - else { + } else { $html = Mage::helper('customer')->__('The customer does not have default billing address.'); } return $html; } + /** + * @return string + */ public function getAccordionHtml() { return $this->getChildHtml('accordion'); } + /** + * @return string + */ public function getSalesHtml() { return $this->getChildHtml('sales'); } + /** + * @return string + */ public function getTabLabel() { return Mage::helper('customer')->__('Customer View'); } + /** + * @return string + */ public function getTabTitle() { return Mage::helper('customer')->__('Customer View'); } + /** + * @return bool + */ public function canShowTab() { if (Mage::registry('current_customer')->getId()) { @@ -204,6 +243,9 @@ public function canShowTab() return false; } + /** + * @return bool + */ public function isHidden() { if (Mage::registry('current_customer')->getId()) { diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php b/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php index cc48a24aea5..1b9f29a2e2a 100644 --- a/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php +++ b/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/File.php @@ -188,8 +188,8 @@ protected function _drawElementHtml($element, array $attributes, $closed = true) /** * Return escaped value * - * @param int $index - * @return string + * @param string|null $index + * @return false|string */ public function getEscapedValue($index = null) { diff --git a/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/Image.php b/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/Image.php index e5422721947..3b6de921a8c 100644 --- a/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/Image.php +++ b/app/code/core/Mage/Adminhtml/Block/Customer/Form/Element/Image.php @@ -80,7 +80,7 @@ protected function _getPreviewHtml() /** * Return Image URL - * @return string + * @return string|false */ protected function _getPreviewUrl() { diff --git a/app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php b/app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php index 66d7eb297bc..f834066da36 100644 --- a/app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php +++ b/app/code/core/Mage/Adminhtml/Block/Newsletter/Subscriber/Grid/Filter/Website.php @@ -28,8 +28,14 @@ */ class Mage_Adminhtml_Block_Newsletter_Subscriber_Grid_Filter_Website extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select { + /** + * @var Mage_Core_Model_Resource_Website_Collection + */ protected $_websiteCollection = null; + /** + * @return array[] + */ protected function _getOptions() { $result = $this->getCollection()->toOptionArray(); @@ -37,9 +43,13 @@ protected function _getOptions() return $result; } + /** + * @return Mage_Core_Model_Resource_Website_Collection + * @throws Mage_Core_Exception + */ public function getCollection() { - if(is_null($this->_websiteCollection)) { + if (is_null($this->_websiteCollection)) { $this->_websiteCollection = Mage::getResourceModel('core/website_collection') ->load(); } @@ -49,11 +59,14 @@ public function getCollection() return $this->_websiteCollection; } + /** + * @return array|null + * @throws Mage_Core_Exception + */ public function getCondition() { - $id = $this->getValue(); - if(!$id) { + if (!$id) { return null; } diff --git a/app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php b/app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php index 9ea09091f08..38f150a3cb8 100644 --- a/app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php +++ b/app/code/core/Mage/Adminhtml/Block/Review/Grid/Filter/Type.php @@ -28,6 +28,9 @@ */ class Mage_Adminhtml_Block_Review_Grid_Filter_Type extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select { + /** + * @return array + */ protected function _getOptions() { return [ @@ -38,6 +41,9 @@ protected function _getOptions() ]; } + /** + * @return int + */ public function getCondition() { if ($this->getValue() == 1) { diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Creditmemo/Grid.php b/app/code/core/Mage/Adminhtml/Block/Sales/Creditmemo/Grid.php index 9528e85133c..f54c9ae1ac9 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Creditmemo/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Creditmemo/Grid.php @@ -46,6 +46,10 @@ protected function _getCollectionClass() return 'sales/order_creditmemo_grid_collection'; } + /** + * @inheritDoc + * @throws Exception + */ protected function _prepareCollection() { $collection = Mage::getResourceModel($this->_getCollectionClass()); @@ -53,6 +57,10 @@ protected function _prepareCollection() return parent::_prepareCollection(); } + /** + * @inheritDoc + * @throws Exception + */ protected function _prepareColumns() { $this->addColumn('increment_id', [ @@ -100,7 +108,8 @@ protected function _prepareColumns() 'currency' => 'order_currency_code', ]); - $this->addColumn('action', + $this->addColumn( + 'action', [ 'header' => Mage::helper('sales')->__('Action'), 'width' => '50px', @@ -116,7 +125,8 @@ protected function _prepareColumns() 'filter' => false, 'sortable' => false, 'is_system' => true - ]); + ] + ); $this->addExportType('*/*/exportCsv', Mage::helper('sales')->__('CSV')); $this->addExportType('*/*/exportExcel', Mage::helper('sales')->__('Excel XML')); @@ -124,6 +134,9 @@ protected function _prepareColumns() return parent::_prepareColumns(); } + /** + * @return $this + */ protected function _prepareMassaction() { $this->setMassactionIdField('entity_id'); @@ -138,19 +151,27 @@ protected function _prepareMassaction() return $this; } + /** + * @param Mage_Sales_Model_Order_Creditmemo $row + * @return false|string + */ public function getRowUrl($row) { if (!Mage::getSingleton('admin/session')->isAllowed('sales/order/creditmemo')) { return false; } - return $this->getUrl('*/sales_creditmemo/view', + return $this->getUrl( + '*/sales_creditmemo/view', [ 'creditmemo_id'=> $row->getId(), ] ); } + /** + * @return string + */ public function getGridUrl() { return $this->getUrl('*/*/*', ['_current' => true]); diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Invoice/Grid.php b/app/code/core/Mage/Adminhtml/Block/Sales/Invoice/Grid.php index 1df292875ac..c68a1f73823 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Invoice/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Invoice/Grid.php @@ -48,6 +48,10 @@ protected function _getCollectionClass() return 'sales/order_invoice_grid_collection'; } + /** + * @inheritDoc + * @throws Exception + */ protected function _prepareCollection() { $collection = Mage::getResourceModel($this->_getCollectionClass()); @@ -55,6 +59,10 @@ protected function _prepareCollection() return parent::_prepareCollection(); } + /** + * @inheritDoc + * @throws Exception + */ protected function _prepareColumns() { $this->addColumn('increment_id', [ @@ -102,7 +110,8 @@ protected function _prepareColumns() 'currency' => 'order_currency_code', ]); - $this->addColumn('action', + $this->addColumn( + 'action', [ 'header' => Mage::helper('sales')->__('Action'), 'width' => '50px', @@ -118,7 +127,8 @@ protected function _prepareColumns() 'filter' => false, 'sortable' => false, 'is_system' => true - ]); + ] + ); $this->addExportType('*/*/exportCsv', Mage::helper('sales')->__('CSV')); $this->addExportType('*/*/exportExcel', Mage::helper('sales')->__('Excel XML')); @@ -126,6 +136,9 @@ protected function _prepareColumns() return parent::_prepareColumns(); } + /** + * @return $this + */ protected function _prepareMassaction() { $this->setMassactionIdField('entity_id'); @@ -140,19 +153,27 @@ protected function _prepareMassaction() return $this; } + /** + * @param Mage_Sales_Model_Order_Invoice $row + * @return false|string + */ public function getRowUrl($row) { if (!Mage::getSingleton('admin/session')->isAllowed('sales/order/invoice')) { return false; } - return $this->getUrl('*/sales_invoice/view', + return $this->getUrl( + '*/sales_invoice/view', [ 'invoice_id'=> $row->getId(), ] ); } + /** + * @return string + */ public function getGridUrl() { return $this->getUrl('*/*/grid', ['_current' => true]); diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php b/app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php index 655e8ec44d6..35077383124 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Items/Abstract.php @@ -132,7 +132,7 @@ public function getItemRenderer($type) * * @param string $column * @param string $compositePart - * @return Mage_Core_Block_Abstract + * @return false|Mage_Core_Block_Abstract */ public function getColumnRenderer($column, $compositePart='') { diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Abstract.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Abstract.php index 69e9fef2b5f..d27de1f35b6 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Abstract.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Abstract.php @@ -48,13 +48,16 @@ public function getSidebarStorageAction() /** * Retrieve display block availability * - * @return bool + * @return int */ public function canDisplay() { return $this->getCustomerId(); } + /** + * @return bool + */ public function canDisplayItemQty() { return false; @@ -138,12 +141,12 @@ public function getItems() /* * Filtering items by allowed product type */ - foreach($items as $key => $item) { + foreach ($items as $key => $item) { if ($item instanceof Mage_Catalog_Model_Product) { $type = $item->getTypeId(); - } else if ($item instanceof Mage_Sales_Model_Order_Item) { + } elseif ($item instanceof Mage_Sales_Model_Order_Item) { $type = $item->getProductType(); - } else if ($item instanceof Mage_Sales_Model_Quote_Item) { + } elseif ($item instanceof Mage_Sales_Model_Quote_Item) { $type = $item->getProductType(); } else { $type = ''; @@ -174,6 +177,9 @@ public function getItemCollection() return false; } + /** + * @return bool + */ public function canDisplayPrice() { return true; diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Reorder.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Reorder.php index b102f81b569..7fb3f904c87 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Reorder.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Reorder.php @@ -42,6 +42,9 @@ protected function _construct() $this->setDataId('reorder'); } + /** + * @return string + */ public function getHeaderText() { return Mage::helper('sales')->__('Last Ordered Items'); @@ -86,16 +89,25 @@ public function getItemCollection() return false; } + /** + * @return false + */ public function canDisplayItemQty() { return false; } + /** + * @return false + */ public function canRemoveItems() { return false; } + /** + * @return false + */ public function canDisplayPrice() { return false; diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Viewed.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Viewed.php index 0ef15c872b7..3cbc37629ae 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Viewed.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Viewed.php @@ -37,7 +37,7 @@ protected function _construct() /** * Retrieve display block availability * - * @return bool + * @return int|false */ public function canDisplay() { @@ -47,13 +47,16 @@ public function canDisplay() /** * Retrieve availability removing items in block * - * @return bool + * @return false */ public function canRemoveItems() { return false; } + /** + * @return string + */ public function getHeaderText() { return Mage::helper('sales')->__('Recently Viewed'); diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php index 36ebe8b1a5d..1cab53c5842 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Create/Sidebar/Wishlist.php @@ -26,8 +26,7 @@ * @package Mage_Adminhtml * @author Magento Core Team */ -class Mage_Adminhtml_Block_Sales_Order_Create_Sidebar_Wishlist - extends Mage_Adminhtml_Block_Sales_Order_Create_Sidebar_Abstract +class Mage_Adminhtml_Block_Sales_Order_Create_Sidebar_Wishlist extends Mage_Adminhtml_Block_Sales_Order_Create_Sidebar_Abstract { /** * Storage action on selected item @@ -43,6 +42,9 @@ protected function _construct() $this->setDataId('wishlist'); } + /** + * @return string + */ public function getHeaderText() { return Mage::helper('sales')->__('Wishlist'); @@ -106,7 +108,7 @@ public function getIdentifierId($item) } /** - * @inheritDoc + * @return false|int */ public function canDisplay() { diff --git a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php index 357a32f3d7b..b47e370b0a7 100644 --- a/app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php +++ b/app/code/core/Mage/Adminhtml/Block/Sales/Order/Grid.php @@ -48,6 +48,10 @@ protected function _getCollectionClass() return 'sales/order_grid_collection'; } + /** + * @inheritDoc + * @throws Exception + */ protected function _prepareCollection() { $collection = Mage::getResourceModel($this->_getCollectionClass()); @@ -55,9 +59,12 @@ protected function _prepareCollection() return parent::_prepareCollection(); } + /** + * @inheritDoc + * @throws Mage_Core_Model_Store_Exception + */ protected function _prepareColumns() { - $this->addColumn('real_order_id', [ 'header' => Mage::helper('sales')->__('Order #'), 'width' => '100px', @@ -116,7 +123,8 @@ protected function _prepareColumns() ]); if (Mage::getSingleton('admin/session')->isAllowed('sales/order/actions/view')) { - $this->addColumn('action', + $this->addColumn( + 'action', [ 'header' => Mage::helper('sales')->__('Action'), 'width' => '50px', @@ -134,7 +142,8 @@ protected function _prepareColumns() 'sortable' => false, 'index' => 'stores', 'is_system' => true, - ]); + ] + ); } $this->addRssList('rss/order/new', Mage::helper('sales')->__('New Order RSS')); @@ -144,6 +153,9 @@ protected function _prepareColumns() return parent::_prepareColumns(); } + /** + * @return $this + */ protected function _prepareMassaction() { $this->setMassactionIdField('entity_id'); @@ -199,6 +211,10 @@ protected function _prepareMassaction() return $this; } + /** + * @param Mage_Sales_Model_Order $row + * @return false|string + */ public function getRowUrl($row) { if (Mage::getSingleton('admin/session')->isAllowed('sales/order/actions/view')) { @@ -207,6 +223,9 @@ public function getRowUrl($row) return false; } + /** + * @return string + */ public function getGridUrl() { return $this->getUrl('*/*/grid', ['_current'=>true]); diff --git a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php index c1fc06aeb21..a9fc8e826cf 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Config/Form/Fieldset.php @@ -192,7 +192,7 @@ protected function _getExtraJs($element, $tooltipsExist = false) * Collapsed or expanded fieldset when page loaded? * * @param Varien_Data_Form_Element_Abstract $element - * @return bool + * @return int|bool */ protected function _getCollapseState($element) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php b/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php index 258945e5d2a..3f0db3ce422 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Edit.php @@ -189,7 +189,7 @@ public function getLoadButtonHtml() /** * Return edit flag for block * - * @return bool + * @return int|string */ public function getEditMode() { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Grid/Filter/Type.php b/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Grid/Filter/Type.php index 4e066d10b4f..d6d86895a3a 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Grid/Filter/Type.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Email/Template/Grid/Filter/Type.php @@ -26,8 +26,7 @@ * @package Mage_Adminhtml * @author Magento Core Team */ -class Mage_Adminhtml_Block_System_Email_Template_Grid_Filter_Type - extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select +class Mage_Adminhtml_Block_System_Email_Template_Grid_Filter_Type extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select { protected static $_types = [ null => null, @@ -35,6 +34,9 @@ class Mage_Adminhtml_Block_System_Email_Template_Grid_Filter_Type Mage_Newsletter_Model_Template::TYPE_TEXT => 'Text', ]; + /** + * @return array + */ protected function _getOptions() { $result = []; @@ -45,9 +47,12 @@ protected function _getOptions() return $result; } + /** + * @return array|null + */ public function getCondition() { - if(is_null($this->getValue())) { + if (is_null($this->getValue())) { return null; } diff --git a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php index 59a0d1d5c14..00e9bc4b8a1 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Group.php @@ -27,9 +27,12 @@ * @author Magento Core Team * @deprecated after 1.13.1.0 use Mage_Adminhtml_Block_System_Store_Tree */ -class Mage_Adminhtml_Block_System_Store_Grid_Render_Group - extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract +class Mage_Adminhtml_Block_System_Store_Grid_Render_Group extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract { + /** + * @param Varien_Object $row + * @return string|null + */ public function render(Varien_Object $row) { if (!$row->getData($this->getColumn()->getIndex())) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php index b9468334cd0..c06cf41e23c 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Store.php @@ -27,9 +27,12 @@ * @author Magento Core Team * @deprecated after 1.13.1.0 use Mage_Adminhtml_Block_System_Store_Tree */ -class Mage_Adminhtml_Block_System_Store_Grid_Render_Store - extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract +class Mage_Adminhtml_Block_System_Store_Grid_Render_Store extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract { + /** + * @param Varien_Object $row + * @return string|null + */ public function render(Varien_Object $row) { if (!$row->getData($this->getColumn()->getIndex())) { diff --git a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Website.php b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Website.php index aacf766b1e2..605aa3f83ca 100644 --- a/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Website.php +++ b/app/code/core/Mage/Adminhtml/Block/System/Store/Grid/Render/Website.php @@ -27,9 +27,12 @@ * @author Magento Core Team * @deprecated after 1.13.1.0 use Mage_Adminhtml_Block_System_Store_Tree */ -class Mage_Adminhtml_Block_System_Store_Grid_Render_Website - extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract +class Mage_Adminhtml_Block_System_Store_Grid_Render_Website extends Mage_Adminhtml_Block_Widget_Grid_Column_Renderer_Abstract { + /** + * @param Varien_Object $row + * @return string + */ public function render(Varien_Object $row) { return '' . parent::getHtml() . ''; } + /** + * @return array[] + */ protected function _getOptions() { return [ @@ -51,17 +57,18 @@ protected function _getOptions() ]; } + /** + * @return array|null + */ public function getCondition() { if ($this->getValue()) { return $this->getColumn()->getValue(); - } - else { + } else { return [ ['neq'=>$this->getColumn()->getValue()], ['is'=>new Zend_Db_Expr('NULL')] ]; } - //return array('like'=>'%'.$this->getValue().'%'); } } diff --git a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php index f1977e1bf40..bcf3767ba61 100644 --- a/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php +++ b/app/code/core/Mage/Adminhtml/Block/Widget/Grid/Column/Filter/Select.php @@ -28,6 +28,9 @@ */ class Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Select extends Mage_Adminhtml_Block_Widget_Grid_Column_Filter_Abstract { + /** + * @return array[] + */ protected function _getOptions() { $emptyOption = ['value' => null, 'label' => '']; @@ -39,7 +42,7 @@ protected function _getOptions() } $colOptions = $this->getColumn()->getOptions(); - if (!empty($colOptions) && is_array($colOptions) ) { + if (!empty($colOptions) && is_array($colOptions)) { $options = [$emptyOption]; foreach ($colOptions as $value => $label) { $options[] = ['value' => $value, 'label' => $label]; @@ -58,15 +61,18 @@ protected function _getOptions() */ protected function _renderOption($option, $value) { - $selected = (($option['value'] == $value && (!is_null($value))) ? ' selected="selected"' : '' ); + $selected = (($option['value'] == $value && (!is_null($value))) ? ' selected="selected"' : ''); return ''; } + /** + * @return string + */ public function getHtml() { $html = '