diff --git a/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php b/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php index e8b6c69a9fc..f6ca1175b7a 100644 --- a/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php +++ b/app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php @@ -434,11 +434,11 @@ public function getFilterElementName($attributeCode) * Get row edit URL. * * @param Mage_Catalog_Model_Resource_Eav_Attribute $row - * @return false + * @return string */ public function getRowUrl($row) { - return false; + return ''; } /** diff --git a/app/code/core/Mage/ImportExport/Helper/Data.php b/app/code/core/Mage/ImportExport/Helper/Data.php index 33d499afc26..0afc562f314 100644 --- a/app/code/core/Mage/ImportExport/Helper/Data.php +++ b/app/code/core/Mage/ImportExport/Helper/Data.php @@ -37,7 +37,9 @@ class Mage_ImportExport_Helper_Data extends Mage_Core_Helper_Data */ public function getMaxUploadSize() { - return min(ini_get('post_max_size'), ini_get('upload_max_filesize')); + $postMaxSizeBytes = ini_parse_quantity(ini_get('post_max_size')); + $uploadMaxSizeBytes = ini_parse_quantity(ini_get('upload_max_filesize')); + return min($postMaxSizeBytes, $uploadMaxSizeBytes); } /** diff --git a/app/code/core/Mage/ImportExport/Model/Export.php b/app/code/core/Mage/ImportExport/Model/Export.php index b8d596c810f..9893ce2744e 100644 --- a/app/code/core/Mage/ImportExport/Model/Export.php +++ b/app/code/core/Mage/ImportExport/Model/Export.php @@ -65,7 +65,9 @@ protected function _getEntityAdapter() if (isset($validTypes[$this->getEntity()])) { try { - $this->_entityAdapter = Mage::getModel($validTypes[$this->getEntity()]['model']); + /** @var Mage_ImportExport_Model_Export_Entity_Abstract $_entityAdapter */ + $_entityAdapter = Mage::getModel($validTypes[$this->getEntity()]['model']); + $this->_entityAdapter = $_entityAdapter; } catch (Exception $e) { Mage::logException($e); Mage::throwException( @@ -104,7 +106,9 @@ protected function _getWriter() if (isset($validWriters[$this->getFileFormat()])) { try { - $this->_writer = Mage::getModel($validWriters[$this->getFileFormat()]['model']); + /** @var Mage_ImportExport_Model_Export_Adapter_Abstract $_writer */ + $_writer = Mage::getModel($validWriters[$this->getFileFormat()]['model']); + $this->_writer = $_writer; } catch (Exception $e) { Mage::logException($e); Mage::throwException( @@ -185,8 +189,7 @@ public function exportFile() Mage::throwException( Mage::helper('importexport')->__('There is no data for export') ); - } - if ($result['rows']) { + } else { $this->addLogComment([ Mage::helper('importexport')->__('Exported %s rows.', $result['rows']), Mage::helper('importexport')->__('Export has been done.') diff --git a/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php b/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php index 836024dc8b0..ed2d8ecfc29 100644 --- a/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php @@ -52,7 +52,7 @@ abstract class Mage_ImportExport_Model_Export_Entity_Abstract /** * Entity type id. * - * @var int + * @var string|null */ protected $_entityTypeId; @@ -170,7 +170,10 @@ public function __construct() { $entityCode = $this->getEntityTypeCode(); $this->_entityTypeId = Mage::getSingleton('eav/config')->getEntityType($entityCode)->getEntityTypeId(); - $this->_connection = Mage::getSingleton('core/resource')->getConnection('write'); + + /** @var Varien_Db_Adapter_Pdo_Mysql $_connection */ + $_connection = Mage::getSingleton('core/resource')->getConnection('write'); + $this->_connection = $_connection; } /** @@ -436,7 +439,7 @@ abstract public function getEntityTypeCode(); /** * Entity type ID getter. * - * @return int + * @return string|null */ public function getEntityTypeId() { diff --git a/app/code/core/Mage/ImportExport/Model/Import.php b/app/code/core/Mage/ImportExport/Model/Import.php index 688717f1e6f..89527a1e637 100644 --- a/app/code/core/Mage/ImportExport/Model/Import.php +++ b/app/code/core/Mage/ImportExport/Model/Import.php @@ -56,7 +56,7 @@ class Mage_ImportExport_Model_Import extends Mage_ImportExport_Model_Abstract /** * Entity invalidated indexes. * - * @var Mage_ImportExport_Model_Import_Entity_Abstract + * @var array> */ protected static $_entityInvalidatedIndexes = [ 'catalog_product' => [ @@ -80,7 +80,9 @@ protected function _getEntityAdapter() if (isset($validTypes[$this->getEntity()])) { try { - $this->_entityAdapter = Mage::getModel($validTypes[$this->getEntity()]['model']); + /** @var Mage_ImportExport_Model_Import_Entity_Abstract $_entityAdapter */ + $_entityAdapter = Mage::getModel($validTypes[$this->getEntity()]['model']); + $this->_entityAdapter = $_entityAdapter; } catch (Exception $e) { Mage::logException($e); Mage::throwException( @@ -366,7 +368,7 @@ public function expandSource() if (!empty($row[$colName])) { preg_match($regExps[$regExpType], $row[$colName], $m); - $row[$colName] = $m[1] . ($m[2] + $size) . ($regExpType == 'middle' ? $m[3] : ''); + $row[$colName] = $m[1] . ((int) $m[2] + $size) . ($regExpType == 'middle' ? $m[3] : ''); } } $writer->writeRow($row); diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php index eb5594e1136..572535fd856 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php @@ -33,7 +33,7 @@ abstract class Mage_ImportExport_Model_Import_Entity_Abstract /** * DB connection. * - * @var Varien_Convert_Adapter_Interface + * @var Varien_Db_Adapter_Pdo_Mysql */ protected $_connection; @@ -54,7 +54,7 @@ abstract class Mage_ImportExport_Model_Import_Entity_Abstract /** * Entity type id. * - * @var int + * @var string|null */ protected $_entityTypeId; @@ -183,10 +183,13 @@ abstract class Mage_ImportExport_Model_Import_Entity_Abstract public function __construct() { - $entityType = Mage::getSingleton('eav/config')->getEntityType($this->getEntityTypeCode()); + $entityType = Mage::getSingleton('eav/config')->getEntityType($this->getEntityTypeCode()); $this->_entityTypeId = $entityType->getEntityTypeId(); $this->_dataSourceModel = Mage_ImportExport_Model_Import::getDataSourceModel(); - $this->_connection = Mage::getSingleton('core/resource')->getConnection('write'); + + /** @var Varien_Db_Adapter_Pdo_Mysql $_connection */ + $_connection = Mage::getSingleton('core/resource')->getConnection('write'); + $this->_connection = $_connection; } /** @@ -398,7 +401,7 @@ abstract public function getEntityTypeCode(); /** * Entity type ID getter. * - * @return int + * @return string|null */ public function getEntityTypeId() { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php index 6c1771b734e..3ad37c5afb3 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php @@ -369,6 +369,7 @@ protected function _saveCustomers() $entityRowsIn = []; $entityRowsUp = []; $attributes = []; + $entityId = null; $oldCustomersToLower = array_change_key_case($this->_oldCustomers, CASE_LOWER); diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php index 0a4cf80d21e..2acd52bbc58 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php @@ -416,7 +416,7 @@ class Mage_ImportExport_Model_Import_Entity_Product extends Mage_ImportExport_Mo /** * url_key attribute id * - * @var int + * @var string|false|null */ protected $_urlKeyAttributeId; @@ -901,6 +901,8 @@ protected function _saveCustomOptions() 'updated_at' => Varien_Date::now() ]; } + + $prevOptionId = 0; if ($rowIsMain) { $solidParams = [ 'option_id' => $nextOptionId, @@ -1152,6 +1154,7 @@ protected function _saveLinks() $productIds = []; $linkRows = []; $positionRows = []; + $sku = null; foreach ($bunch as $rowNum => $rowData) { $this->_filterRowData($rowData); @@ -1362,6 +1365,7 @@ protected function _saveProducts() $tierPrices = []; $groupPrices = []; $mediaGallery = []; + $rowSku = null; $uploadedGalleryFiles = []; $previousType = null; $previousAttributeSet = null; @@ -2207,7 +2211,7 @@ public function getAffectedEntityIds() /** * Get product url_key attribute id * - * @return null|int + * @return string|false|null */ protected function _getUrlKeyAttributeId() { diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php index cf70478bd47..30e2a985720 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php @@ -356,6 +356,8 @@ public function saveData() $newSku = $this->_entityModel->getNewSku(); $oldSku = $this->_entityModel->getOldSku(); $productSuperData = []; + $productSuperAttrId = null; + $productId = null; $productData = null; /** @var Mage_ImportExport_Model_Resource_Helper_Mysql4 $helper */ $helper = Mage::getResourceHelper('importexport'); diff --git a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php index 9ea48d059b6..a01916f0b96 100644 --- a/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php +++ b/app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php @@ -65,6 +65,7 @@ public function saveData() $newSku = $this->_entityModel->getNewSku(); $oldSku = $this->_entityModel->getOldSku(); $attributes = []; + $productData = []; // pre-load attributes parameters $select = $connection->select() @@ -101,6 +102,7 @@ public function saveData() } else { continue; } + $scope = $this->_entityModel->getRowScope($rowData); if (Mage_ImportExport_Model_Import_Entity_Product::SCOPE_DEFAULT == $scope) { $productData = $newSku[$rowData[Mage_ImportExport_Model_Import_Entity_Product::COL_SKU]]; diff --git a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php index af144e6827d..4666a1bc916 100644 --- a/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php +++ b/app/code/core/Mage/Shipping/Model/Carrier/Abstract.php @@ -97,7 +97,7 @@ abstract class Mage_Shipping_Model_Carrier_Abstract extends Varien_Object /** * Rate result data * - * @var Mage_Shipping_Model_Rate_Result|null + * @var Mage_Shipping_Model_Rate_Result|Mage_Shipping_Model_Tracking_Result|null */ protected $_result; diff --git a/app/code/core/Mage/Uploader/Helper/File.php b/app/code/core/Mage/Uploader/Helper/File.php index 3d068014145..9ecd49ab05f 100644 --- a/app/code/core/Mage/Uploader/Helper/File.php +++ b/app/code/core/Mage/Uploader/Helper/File.php @@ -703,7 +703,7 @@ public function getUploadMaxSize() /** * Get max upload size * - * @return mixed + * @return string */ public function getDataMaxSize() { diff --git a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php index e4af94befeb..f449d8e1c78 100644 --- a/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php +++ b/app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php @@ -85,10 +85,18 @@ class Mage_Usa_Model_Shipping_Carrier_Usps extends Mage_Usa_Model_Shipping_Carri */ protected $_rawRequest = null; + + /** + * Raw rate tracking request data + * + * @var Varien_Object|null + */ + protected $_rawTrackRequest = null; + /** * Rate result data * - * @var Mage_Shipping_Model_Rate_Result|null + * @var Mage_Shipping_Model_Rate_Result|Mage_Shipping_Model_Tracking_Result|null */ protected $_result = null; @@ -425,7 +433,7 @@ protected function _getXmlQuotes() * * @link http://www.usps.com/webtools/htm/Rate-Calculators-v2-3.htm * @param string $response - * @return Mage_Shipping_Model_Rate_Result + * @return Mage_Shipping_Model_Rate_Result|void */ protected function _parseXmlResponse($response) { @@ -512,6 +520,7 @@ protected function _parseXmlResponse($response) } } } + /** * Get configuration data of carrier * @@ -901,7 +910,7 @@ public function getTracking($trackingData) /** * Set tracking request * - * @return null + * @return void */ protected function setTrackingRequest() { @@ -960,7 +969,7 @@ protected function _getXmlTracking($trackingData) * * @param array $trackingValue * @param string $response - * @return null + * @return void */ protected function _parseXmlTrackingResponse($trackingValue, $response) { diff --git a/phpstan.dist.baseline.neon b/phpstan.dist.baseline.neon index 8fd0d3944fa..58d3dfd945d 100644 --- a/phpstan.dist.baseline.neon +++ b/phpstan.dist.baseline.neon @@ -3340,46 +3340,11 @@ parameters: count: 4 path: app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php - - - message: "#^Return type \\(false\\) of method Mage_ImportExport_Block_Adminhtml_Export_Filter\\:\\:getRowUrl\\(\\) should be compatible with return type \\(string\\) of method Mage_Adminhtml_Block_Widget_Grid\\:\\:getRowUrl\\(\\)$#" - count: 1 - path: app/code/core/Mage/ImportExport/Block/Adminhtml/Export/Filter.php - - - - message: "#^Method Mage_ImportExport_Helper_Data\\:\\:getMaxUploadSize\\(\\) should return int but returns string\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Helper/Data.php - - - - message: "#^If condition is always true\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Export_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - - - message: "#^Property Mage_ImportExport_Model_Export\\:\\:\\$_writer \\(Mage_ImportExport_Model_Export_Adapter_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_connection \\(Varien_Db_Adapter_Pdo_Mysql\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - - - message: "#^Property Mage_ImportExport_Model_Export_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Export/Entity/Abstract.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 @@ -3410,166 +3375,21 @@ parameters: count: 1 path: app/code/core/Mage/ImportExport/Model/Export/Entity/Product.php - - - message: "#^Binary operation \"\\+\" between string and 50\\|int\\<100, max\\> results in an error\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - - - message: "#^Property Mage_ImportExport_Model_Import\\:\\:\\$_entityAdapter \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept Mage_Core_Model_Abstract\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - - - message: "#^Static property Mage_ImportExport_Model_Import\\:\\:\\$_entityInvalidatedIndexes \\(Mage_ImportExport_Model_Import_Entity_Abstract\\) does not accept default value of type array\\\\>\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import.php - - message: "#^Method Mage_Eav_Model_Entity_Attribute_Source_Interface\\:\\:getAllOptions\\(\\) invoked with 1 parameter, 0 required\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_connection \\(Varien_Convert_Adapter_Interface\\) does not accept Varien_Db_Adapter_Interface\\|false\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Abstract\\:\\:\\$_entityTypeId \\(int\\) does not accept string\\|null\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Abstract.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Variable \\$entityId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Customer/Address.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:delete\\(\\)\\.$#" - count: 8 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:fetchPairs\\(\\)\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertMultiple\\(\\)\\.$#" - count: 3 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:insertOnDuplicate\\(\\)\\.$#" - count: 14 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:query\\(\\)\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:quoteInto\\(\\)\\.$#" - count: 12 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Call to an undefined method Varien_Convert_Adapter_Interface\\:\\:select\\(\\)\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Method Mage_ImportExport_Model_Import_Entity_Product\\:\\:getConnection\\(\\) should return Varien_Db_Adapter_Pdo_Mysql but returns Varien_Convert_Adapter_Interface\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - message: "#^Negated boolean expression is always true\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Property Mage_ImportExport_Model_Import_Entity_Product\\:\\:\\$_urlKeyAttributeId \\(int\\) does not accept string\\|false\\|null\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - message: "#^Result of \\|\\| is always true\\.$#" count: 1 path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - message: "#^Variable \\$prevOptionId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$rowSku might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$sku might not be defined\\.$#" - count: 2 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product.php - - - - message: "#^Variable \\$productId might not be defined\\.$#" - count: 4 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php - - - - message: "#^Variable \\$productSuperAttrId might not be defined\\.$#" - count: 1 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Configurable.php - - - - message: "#^Variable \\$productData might not be defined\\.$#" - count: 3 - path: app/code/core/Mage/ImportExport/Model/Import/Entity/Product/Type/Grouped.php - - message: "#^Method Mage_Index_Model_Lock\\:\\:getInstance\\(\\) should return \\$this\\(Mage_Index_Model_Lock\\) but returns Mage_Index_Model_Lock\\.$#" count: 1 @@ -5045,31 +4865,6 @@ parameters: count: 2 path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Ups.php - - - message: "#^Access to an undefined property Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:\\$_rawTrackRequest\\.$#" - count: 2 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:_parseXmlResponse\\(\\) should return Mage_Shipping_Model_Rate_Result but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:_parseXmlTrackingResponse\\(\\) should return null but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - - message: "#^Method Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:setTrackingRequest\\(\\) should return null but return statement is missing\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - - - message: "#^Property Mage_Usa_Model_Shipping_Carrier_Usps\\:\\:\\$_result \\(Mage_Shipping_Model_Rate_Result\\|null\\) does not accept Mage_Shipping_Model_Tracking_Result\\.$#" - count: 1 - path: app/code/core/Mage/Usa/Model/Shipping/Carrier/Usps.php - - message: "#^Call to an undefined method Mage_Core_Helper_Abstract\\:\\:priceIncludesTax\\(\\)\\.$#" count: 1