Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cms breadcrumb issue in 1.9.3.0 #119

Merged
merged 1 commit into from
Jan 8, 2017
Merged

Fix cms breadcrumb issue in 1.9.3.0 #119

merged 1 commit into from
Jan 8, 2017

Conversation

drobinson
Copy link
Collaborator

$breadcrumbs is not always defined and should have at least some checking. Results in fatal exception on frontend in some cases.

@drobinson drobinson added the review needed Problem should be verified label Oct 14, 2016
Flyingmana
Flyingmana approved these changes Oct 19, 2016
View reviewed changes
Copy link
Contributor

@Flyingmana Flyingmana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did someone also check the triggered event?

@Flyingmana Flyingmana merged commit 0c50f33 into OpenMage:1.9.3.0 Jan 8, 2017
@Flyingmana
Copy link
Contributor

also picked into 1.9.3.1

@tmotyl tmotyl mentioned this pull request Mar 16, 2017
Closed
@sreichel sreichel added bug and removed review needed Problem should be verified labels Jan 11, 2018
@sreichel sreichel added the Component: Cms Relates to Mage_Cms label Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeSaferite LeeSaferite LeeSaferite approved these changes

@Flyingmana Flyingmana Flyingmana approved these changes

Assignees
No one assigned
Labels
bug Component: Cms Relates to Mage_Cms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drobinson @Flyingmana @LeeSaferite @sreichel