Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove admin swf files [SUPEE-8788] #121

Merged
merged 1 commit into from
Oct 27, 2016

Conversation

tschifftner
Copy link
Contributor

flex and uploader swf files were removed in patch SUPEE-8788 and therefore also in Magento 1.9.3.0.

@tschifftner tschifftner changed the title Remove admin swf files Remove admin swf files [SUPEE-8788] Oct 18, 2016
@infabo
Copy link

infabo commented Oct 18, 2016

@tschifftner 👍

@drobinson #115

@drobinson
Copy link
Collaborator

@tschifftner thanks. I'm also thinking we can remove the moxieplayer.swf, but still haven't heard a yes/no from Magento https://twitter.com/d_rbn/status/786688518705844224

@infabo Did I miss something from your issue?

@Flyingmana
Copy link
Contributor

I would handle moxieplayer.swf in a complete separate case, its not used for one of magentos basic features and was probably not reviewed yet properly.

Looks like a general movie player plugin from tiny_mce. (removing it in a separate PR together with its plugin entry is sure a good idea, even if magento itself does not)

@infabo
Copy link

infabo commented Oct 19, 2016

@drobinson Nothing to add to #115. I guess the review process will make PRs like this one obsolete in the future.

@infabo
Copy link

infabo commented Oct 19, 2016

Regarding moxieplayer.swf:
It's not done by just removing the swf file and removing addPlayer-function in editor_plugin_src.js.
You have to remove the whole FLASH stuff from the tinymce media plugin (looks a lot and quite cumbersome). Or am I wrong in this regard?

@tschifftner
Copy link
Contributor Author

Could this be merged soon? Anything I could do?

@colinmollenhour colinmollenhour merged commit 2757e6b into OpenMage:1.9.3.0 Oct 27, 2016
@sreichel sreichel added review needed Problem should be verified patch Cleanup labels Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup review needed Problem should be verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants