Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the CSS merging data uri bug #169

Merged
merged 1 commit into from
Feb 10, 2017
Merged

Fixed the CSS merging data uri bug #169

merged 1 commit into from
Feb 10, 2017

Conversation

royduin
Copy link
Contributor

@royduin royduin commented Feb 9, 2017 •
edited
Loading

See: https://github.com/just-better/magento1-css-merge-data-uri-fix

As requested here: justbetter/magento1-css-merge-data-uri-fix#1

Currently only for 1.9.3.1, but this patch should be applied to all versions @seansan.

@royduin royduin mentioned this pull request Feb 9, 2017
Closed
LeeSaferite
LeeSaferite approved these changes Feb 9, 2017
View reviewed changes
Copy link
Contributor

@LeeSaferite LeeSaferite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would capture the quote mark and use it to better qualify the match, but this regex works to exclude single and double quoted data URIs as expected.

@colinmollenhour colinmollenhour merged commit 2fc3a12 into OpenMage:1.9.3.1 Feb 10, 2017
@colinmollenhour
Copy link
Member

Good fix. Thanks @royduin !

@tmotyl tmotyl mentioned this pull request Mar 16, 2017
Closed
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Dec 6, 2017
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
aea22f4 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Dec 6, 2017
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
7efec44 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
@sreichel sreichel added the bug label Jan 11, 2018
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 28, 2018
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
772cd96 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Mar 20, 2018
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
db46d3b 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Jul 17, 2018
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
f2b6ce1 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Sep 19, 2018
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
9e38e4e 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Feb 14, 2019
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
891bf42 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Apr 1, 2019
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
8d427f5 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 22, 2019
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
5399426 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Oct 25, 2019
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
1c6e699 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
@sreichel sreichel added the Component: Core Relates to Mage_Core label Jun 6, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@royduin @edannenberg
[bug-OpenMage#169] Corrupted merged css file when using css data URIs
d7ffc31 
See: https://github.com/just-better/magento1-css-merge-data-uri-fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colinmollenhour colinmollenhour colinmollenhour approved these changes

@LeeSaferite LeeSaferite LeeSaferite approved these changes

Assignees
No one assigned
Labels
bug Component: Core Relates to Mage_Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@royduin @colinmollenhour @LeeSaferite @sreichel