Fixed passing null for str_replace is deprecated for downloadable products #3330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_Block_Adminhtml_Catalog_Product_Edit_Tab_Downloadable_Links
github-actions
bot
added
the
Component: Downloadable
kyrena
changed the title
fballiano
approved these changes
Jun 16, 2023
kiatng
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix
passing null to parameter #3 ($subject) of type array|string is deprecatedforstr_replacewith PHP 8.1/8.2.Perhaps it's not the best way. Only for download product edit page in backend.
The deprecated notice is triggered by
_prepareFileForPathofMage_Downloadable_Helper_File.See also this discussion comment.
Contribution checklist