Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed strtr(): Passing null to parameter #1 ($string) of type string is deprecated #3639

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fixed strtr(): Passing null to parameter #1 ($string) of type string is deprecated #3639

merged 1 commit into from
Nov 10, 2023

Conversation

kiatng
Copy link
Contributor

@kiatng kiatng commented Nov 10, 2023

…is deprecated

Description (*)

This is in my log:

    [type] => 8192:E_DEPRECATED
    [message] => strtr(): Passing null to parameter #1 ($string) of type string is deprecated
    [file] => .../app/code/core/Mage/Catalog/Helper/Product/Url.php
    [line] => 118

It happened once only, I do not know how to replicate it.

@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Nov 10, 2023
@fballiano fballiano changed the title Fixed strtr(): Passing null to parameter #1 ($string) of type string … Fixed strtr(): Passing null to parameter #1 ($string) of type string is deprecated Nov 10, 2023
@fballiano fballiano merged commit 0ac3f19 into OpenMage:main Nov 10, 2023
17 checks passed
@kiatng kiatng deleted the strtr_null_deprecation branch November 11, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fballiano fballiano fballiano approved these changes

@ADDISON74 ADDISON74 ADDISON74 approved these changes

Assignees
No one assigned
Labels
Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiatng @fballiano @ADDISON74