Add quotes to numeric incrementIds - The Sequel #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinmollenhour
requested changes
Nov 27, 2017
|
@colinmollenhour Hi, sorry for getting back so late on this one. I've reverted the original code and only added the single line as per your request. It does make more sense to do it that way considering possible future patches. |
LeeSaferite
reviewed
Dec 5, 2017
tmotyl
reviewed
Dec 7, 2017
tmotyl
approved these changes
Dec 13, 2017
colinmollenhour
approved these changes
Dec 13, 2017
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Dec 14, 2017
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 28, 2018
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Mar 20, 2018
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Jul 17, 2018
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Sep 19, 2018
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Feb 14, 2019
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Apr 1, 2019
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 22, 2019
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Oct 25, 2019
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
edannenberg
pushed a commit
to edannenberg/magento-lts
that referenced
this pull request
Aug 20, 2020
…e::isOrderIncrementIdUsed() Cast increment ids to string to ensure use of index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the second location where queries were built without quotes around increment_id if it was numeric.