Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPCS: fixed php compatibility warning #4148

Merged
merged 9 commits into from
Aug 22, 2024

Conversation

sreichel
Copy link
Contributor

@sreichel sreichel commented Aug 8, 2024

Fixes;

FILE: ...lts/magento-lts/app/code/core/Mage/Core/Helper/EnvironmentConfigLoader.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 71 | ERROR | list() will assign variable from left-to-right since PHP 7.0.
    |       | Ensure all variables in list() are unique to prevent unexpected
    |       | results. (PHPCompatibility.Lists.AssignmentOrder.Affected)
 78 | ERROR | list() will assign variable from left-to-right since PHP 7.0.
    |       | Ensure all variables in list() are unique to prevent unexpected
    |       | results. (PHPCompatibility.Lists.AssignmentOrder.Affected)
--------------------------------------------------------------------------------

Related Pull requeset:

@github-actions github-actions bot added the Component: Core Relates to Mage_Core label Aug 8, 2024
@kiatng kiatng merged commit 9f1659d into OpenMage:main Aug 22, 2024
17 checks passed
@sreichel sreichel deleted the phpccs-phpcompa-2 branch August 22, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Relates to Mage_Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants