Applied Security patch from Magento: PATCH_SUPEE-5344_CE #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -69,13 +73,14 @@ public function actionPreDispatchAdmin($observer) | |||
| $session->login($username, $password, $request); | |||
| $request->setPost('login', null); | |||
| } | |||
| if (!$request->getParam('forwarded')) { | |||
There was a problem hiding this comment.
For the record I'd like to point out that adding this getInternallyForwarded/setInternallyForwarded is silly as the request object supports parameters that are set via code only. When you call setParam you are seting 'userland' parameters. If you want to get a parameter and be sure it was set via code and not the inbound requests you use getUserParam and NOT getParam like the original code had.
LeeSaferite
added a commit
that referenced
this pull request
Feb 10, 2015
Applied Security patch from Magento: PATCH_SUPEE-5344_CE
justinbeaty
added a commit
to justinbeaty/magento-lts
that referenced
this pull request
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.