-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes ZMQ freezes on sendExpression("quit()") #32
Comments
Well looking at the code I think the problem is still there. You only check for the process before send. If we send "quit()" it will kill the process so I think you have to check for it before receive as well. |
@adeas31 i will add it |
@arun3688 still, did you release a new version of OMJulia after the fix? |
@JKRT you mean which fix, this issue |
@JKRT Did we cover this yesterday? |
I already used the latest repository version (commit hash I think @adeas31 is right: The fix for #29 does not work in this case, because the omc process is killed after the process status was checked. |
Sometimes (maybe 1 in 10 or 1 in 20 cases), ZMQ freezes after
sendExpression(omc, "quit()")
.The OMC instance shuts down properly, but the call never returns. I suppose that this could be a threading issue on the side of OMC so that
quit()
sometimes shuts down the process before the answer to the ZMQ message is sent.The clean solution would probably be to look into the ZMQ handling in the OMC, but a quick fix could also be to simply skip the call to
ZMQ.recv
for thequit()
message like this:If it seems that this clutters up the implementation of
sendExpression
too much, it would also be possible to implementquit(omc)
as a separate function.The text was updated successfully, but these errors were encountered: