Update libxml2 to version 2.11.4. #1216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahge
added
CI/Update Submodules
mahge
force-pushed
the
update_libxml2_to_2.11.4
branch
2 times, most recently
from
18be1f4
to
e158344
Compare
- This version comes with CMake support and many other fixes and improvements.
- It is taken from https://github.com/GNOME/libxml2
- The folders: `doc`, `fuzz`, `m4`, `result`, and `test` are removed to save space since they are not needed.
- The required CMake version has been downgraded from 3.18 to 3.15.
Ubuntu focal, one of our supported platforms, comes with CMake 3.16 so that is the maximum CMake version we can require right now.
The libxml required CMake version was upgraded by GNOME/libxml2@a5bc460 in order to use `check_linker_flag` CMake utility function. We do not need that so it is removed and the CMake version is downgraded.
- The CMake support allows OMSimulator to move one step closer to complete CMake based build.
- We are intersted in building only the static library. No shared version.
That means there is not going to be any name conflict. So just output
the library without any posfix (just libxml2.lib instead of libxml2s.lib).
This saves us from having to updated the expected library name in
other places.
- Debug builds still get the 'd' postfix for now. Perhaps this should
be removed as well.
- This will tell libxml2 headers not to add dll direction specifiers
(`__declspec(dllimport)` and `__declspec(dllexport)`)
- This seems to be what is picked by default by cmake. OMTLMSimulator
does not need or use CMake right now, however it links to libraries
built by CMake (within OMSimulator, e.g., libxml2) which get compiled
with /MD. So set it here as well to avoid link time failures.
- It is built as a static library now even on Windows with MSVC.
mahge
force-pushed
the
update_libxml2_to_2.11.4
branch
from
e158344
to
b2af282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version comes with CMake support and many other fixes and improvements.
doc,fuzz,m4,result, andtestare removed to save space since they are not needed.check_linker_flagCMake utility function. We do not need that so it is removed and the CMake version is downgraded.The
CMakesupport allowsOMSimulatorto move one step closer to completeCMakebased build.