Adjust configuration to fit well with OpenModelica. #1245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- OMSimulator standalone has no issues and works just fine. However, we need to consider some things when it is being built as part of OpenModelica.
- Sindials exists in OpenModelica's 3rdParty as well as OMSimulator's
3rdParty. It creates the same named targets in both. This is not
allowed. So if OMSimulator is part of OpenModelica (not standalone)
skip adding its 3rdParty/Sundials and just use the targets already
added by OpenModelica. Just create aliases for them.
- FMIL continues to create issues as usual. This time from across
the horizon. FMIL comes with `minizip `(among other things) and uses
it in the usual contrived FMIL way. OMSimulator also comes with its
own `minizip`. So, as a workaround, just rename OMSimulator's `minizip` to `oms_minizip`
and use it with that name. It should be fine since it is only used
locally and is not supposed to be installed anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMSimulator standalone has no issues and works just fine. However, we need to consider some things when it is being built as part of OpenModelica.
Sundials exists in OpenModelica's 3rdParty as well as OMSimulator's
3rdParty. It creates the same named targets in both. This is not
allowed. So if OMSimulator is part of OpenModelica (not standalone)
skip adding its 3rdParty/Sundials and just use the targets already
added by OpenModelica. Just create aliases for them.
FMIL continues to create issues as usual. This time from across
the horizon. FMIL comes with
minizip(among other things) and usesit in the usual contrived FMIL way. OMSimulator also comes with its
own
minizip. So, as a workaround, just rename OMSimulator'sminiziptooms_minizipand use it with that name. It should be fine since it is only used
locally and is not supposed to be installed anyway.