proto/openmetrics_data_model.proto: Don't assign field number twice #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling `proto/openmetrics_data_model.proto` with `libprotoc` `v3.6.1` fails with: > `protoc failed: open_metrics.proto:198: 18: Field number 2 has already been used in \"openmetrics.SummaryValue\" by field \"int_value\".\n"` In the `SummaryValue` `message` the field number `2` is used twice, once for `int_value` and once for `count`. With this commit, all field numbers within `SummaryValue` are monotonically increasing instead.
|
For what I can tell the bug was introduced with #151. |
|
Can we apply linting to that? |
robskillington
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compiling
proto/openmetrics_data_model.protowithlibprotocv3.6.1failswith:
In the
SummaryValuemessagethe field number2is used twice, once forint_valueand once forcount. With this commit, all field numbers withinSummaryValueare monotonically increasing instead.As far as I can tell this never compiled in the first place, thus backward
compatibility should not be an issue.