Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenRarity rank not calculating correctly on Skulptuur collection #114

Closed
tyoffice opened this issue Feb 7, 2023 · 2 comments
Closed

OpenRarity rank not calculating correctly on Skulptuur collection #114

tyoffice opened this issue Feb 7, 2023 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@tyoffice
Copy link

tyoffice commented Feb 7, 2023

Describe the bug
A clear and concise description of what the bug is.

Information
OpenRarity incorrectly calculating rarity.

To Reproduce
Steps to reproduce the behavior: Compare rarity rank betweek sites. Look at traits in collection. Camera heigh = high is the second rarest trait and rank should reflect that.

Expected behavior
Recalculate rarity on this collection to accurately reflect traits.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment

  • OS: [e.g. iOS]
  • Python [e.g. 3.10.3]
  • Library Version [e.g. 1.0]

Additional context
Add any other context about the problem here.

@tyoffice tyoffice added the bug Something isn't working label Feb 7, 2023
@impreso
Copy link
Contributor

impreso commented Feb 7, 2023

Hi thanks for reporting. This is not a bug and OR works as expected. I checked the collection and Camera Height = High is not a unique trait. Here are all assets with this trait:
https://opensea.io/collection/skulptuur-by-piter-pasma?search[sortAscending]=true&search[sortBy]=UNIT_PRICE&search[stringTraits][0][name]=camera_height&search[stringTraits][0][values][0]=high

We consider whole trait combination when we compute rarity not a single trait and this particular asset has much less rare traits in the combination.

@impreso impreso closed this as completed Feb 7, 2023
@tyoffice
Copy link
Author

tyoffice commented Feb 7, 2023

Do you notice the rarity rank for all other assets with that trait? They are ranked 21-80. This is the only asset with that trait outside of that range and it's ranked 975. It also has a rare environment trait, which is why it should be among the rarest of that group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants