Fix issue with when removing all assigned roles to users

[celinenilla]

After removing a role from a user, nothing is automatically selected in user type thus when that user logs back in, error message appears.

[jannahadlaon]

Findings: Issue is still present.
Tested in: SP-MIS QA
STEPS:

1. Log in as admin
2. Create a user with any role
3. Log out as admin
4. Log in using the users credentials then log out
5. Log back in as admin
6. Remove the assigned roles for the user and save
7. Log in using the user credentials. See issue below

[celinenilla]

@singhkaranvir25 , can you please help out with the expected behaviour for this?

[singhkaranvir25]

@celinenilla @jannahadlaon - As per my discussion with @kneckinator, it was concluded that this issue is caused by interlinking of "Role" with "User Type" configured under "Access Rights"

As soon as the last user role is deleted manually, the user type becomes null. Hence causing the screen with forbidden.

Whereas when user has an expired user role, it can still login and perform the actions on the application. (Which sounds like a separate but related issue). Additional issue observed was that when configuring the roles, fields such as "Center Area" "Companies" etc does not really matter. User has kind of full access.

Hence in my opinion, the expected behaviour of this ticket should be that when a user role is deleted, or expired. "User Type" value should remain intact. Which would allow user to login and have access to the available views such as dashboard.

If the User Type is "Portal" or "Public", then access would look like as follows:

[celinenilla]

@gonzalesedwin1123 , can you please have a look at the suggestion made by karan above?

[jannahadlaon]

Findings: Works as expected in using runboat instance
Tested in: Runboat instance

STEPS:

1. Log in as admin
2. Create a user with any role ( ex. Change request related roles)
3. Log out as admin
4. Log in using the users credentials then log out
5. Log back in as admin
6. Remove the assigned roles for the user and save
7. Log in using the user credentials.
   Verify that no more errors encountered. Screen should still successfully log the user in.
   
8. Log in back as an admin and edit User Type is "Portal" or "Public"
9. Log in as user in step 2 and verify that the screen displayed is:
   

CC: @gonzalesedwin1123

[gonzalesedwin1123]

@celinenilla Can we close this ticket then?

[celinenilla]

Yes, setting to Done, since fixed already