Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properties being dropped when saving addon settings #196

Closed
mikepparks opened this issue May 1, 2023 · 4 comments
Closed

Properties being dropped when saving addon settings #196

mikepparks opened this issue May 1, 2023 · 4 comments

Comments

@mikepparks
Copy link
Contributor

After some testing, it seems that the amount of new properties for addons has caused the JSON doc to expand beyond the 2048 limit from LWIP_HTTPD_POST_MAX_PAYLOAD_LEN in webconfig.cpp. This may impact some of the newly added addons, and was only noticed on hardware since the local web server instance does not have this limitation.
@mikepparks
Copy link
Contributor Author

mikepparks commented May 1, 2023 •
edited
Loading

image
This is a compare against the setAddonsOptions API route. The left is the POST payload. The right is the same doc being returned. (The "WiiExtension" part is local dev work and can be ignored.)

@TheTrainGoes
Copy link
Contributor

Thanks for the info @mikepparks - We will look into this.

@deeebug deeebug mentioned this issue May 2, 2023
Merged
@arntsonl
Copy link
Contributor

arntsonl commented May 3, 2023

Should be fixed! pull latest and try it out

@TheTrainGoes
Copy link
Contributor

This has been addressed in v0.7.1-RC2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mikepparks @arntsonl @TheTrainGoes