Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used Pins Bad Reporting in Web Config (Dev/'main' branch) #391

Closed
4 tasks
arntsonl opened this issue Jul 4, 2023 · 2 comments
Closed
4 tasks

Used Pins Bad Reporting in Web Config (Dev/'main' branch) #391

arntsonl opened this issue Jul 4, 2023 · 2 comments
Assignees
Milestone

Comments

@arntsonl
Copy link
Contributor

arntsonl commented Jul 4, 2023

Prerequisites

Please check the following before posting an issue / bug report.

  • I am running the latest version of the firmware found HERE
  • I have checked the documentation HERE and found no answer
  • I checked to make sure that this issue has not already been filed HERE
  • I am reporting the issue to the correct repository

Context

Please provide all relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.

  • Firmware Version: 'main' latest as of 07/04/2023
  • Name of device: Pico
  • Link to where you purchased the device:
  • Is this a custom build?:
  • Operating System:
  • Browser:

Expected Behavior

Used pins should not be reporting incorrectly on the web config

Current Behavior

Used pins in the add-ons page are reporting incorrectly

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

  1. Enable the Analog Add-on
  2. Set Analog 1 ADC to pin 26 and pin 27 respectively
  3. Save the Add-on page and reload
  4. Set Any other Analog option
  5. Observe the "pin 26" and "pin 27" options report an error with previously defined pins

Screenshots & Files

Please include any relevant screenshots or files here. If you are having issues with a board please include images of the front and back of the board.

analogBug01

@Pelsin
Copy link
Contributor

Pelsin commented Jul 5, 2023

I think the issue is that these pins are used somewhere else but still show up as options in addons page.
This should hide non available pins: #392

Edit: Actually i might have been shooting to quickly here. this introduced some issues with showing pins
@SavageCore cleaned up my mess: https://github.com/OpenStickCommunity/GP2040-CE/pull/393/files

@arntsonl arntsonl added this to the 0.7.3 milestone Jul 11, 2023
@arntsonl
Copy link
Contributor Author

I'm going to close this issue since we fixed this for 0.7.3 and just make a new one as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants