Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOCD slider assumes you're going to map two pins #454

Closed
bsstephan opened this issue Aug 14, 2023 · 3 comments
Closed

SOCD slider assumes you're going to map two pins #454

bsstephan opened this issue Aug 14, 2023 · 3 comments
Assignees
@bsstephan

Comments

@bsstephan
Copy link
Contributor

I thought this was reported before, but I couldn't find it, so I'm writing it down and assigning it to myself for when I get a chance.

options.enabled && isValidPin(options.pinOne) && isValidPin(options.pinTwo) means you can't aside the slider to a simple two-way rocker switch.
@bsstephan bsstephan self-assigned this Aug 14, 2023
@bsstephan
Copy link
Contributor Author

Upon further testing, if pinOne and pinTwo are the same pin, it works fine, so maybe this is a web UI/docs thing more than it is a code change thing.

@bsstephan
Copy link
Contributor Author

I think my pin mapping refactor will nuke this problem.

@bsstephan
Copy link
Contributor Author

#504 and #652 solved this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsstephan bsstephan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bsstephan