Bug: Max retry functionality not working as expected

[dnicolson]

Describe The Bug

When BLE connection errors occur it seems that discover needs to be called again and not just turnOn/turnOff. I tested with 5 second intervals for minutes and the result of the log output below did not change.

To Reproduce

Turn a Bot off and on repeatedly

Expected behavior

Retry attempts to have a different result

Relevant log output

[28/12/2022, 19:13:59] [SwitchBot] Retrying
[28/12/2022, 19:14:00] [SwitchBot] TypeError: Cannot read properties of null (reading 'write')

Config for homebridge-switchbot

{
    "deviceId": "D787C65C8DEB",
    "configDeviceName": "Light",
    "configDeviceType": "Bot",
    "connectionType": "BLE",
    "bot": {
        "mode": "switch",
        "deviceType": "switch"
    },
    "maxRetry": 5,
    "logging": "standard"
}

Screenshots

No response

Device & Model

SwitchBot Bot

Node.js Version

v18.12.1

NPM Version

v8.19.2

Homebridge Version

v1.6.0

Homebridge Switchbot Plugin Version

v2.4.0

Homebridge Config UI X Plugin Version

v4.50.2

Operating System

Raspian

[donavanbecker]

latest beta has the latest node-switchbot beta as a dependency.

[dnicolson]

That helps with the error messages, it doesn't affect the retry behavior though.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[dnicolson]

@donavanbecker I'm not sure why this is invalid, I plan to submit a pull request with the proposed fix after #690 is merged.