Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question About Increased Simulation Time with --dump-commit-trace #470

Open
figuresudo opened this issue Sep 18, 2024 · 1 comment
Open
Assignees
Labels
enhancement New feature or request

Comments

@figuresudo
Copy link

When I enable the --dump-commit-trace option, the instruction sequence is successfully output, but I’ve noticed that the simulation time increases by 3 to 4 times. Could you kindly explain what might be causing this increase in simulation time?

@figuresudo figuresudo added the question Further information is requested label Sep 18, 2024
@poemonsense poemonsense added the enhancement New feature or request label Sep 18, 2024
@poemonsense
Copy link
Member

This is a known performance issue because every line of commit trace requires calling the spike-dasm command.

See https://github.com/OpenXiangShan/difftest/blob/master/src/test/csrc/plugin/spikedasm/spikedasm.cpp#L42-L50

Since we are calling it through the command line instead of function calls, its performance is currently quite slow.

If you have any advice on this, we can discuss how to fix it.

@poemonsense poemonsense removed the question Further information is requested label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants