Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mistake in code style #2323

Closed
Met7 opened this issue Aug 8, 2020 · 1 comment · Fixed by #2324
Closed

Mistake in code style #2323

Met7 opened this issue Aug 8, 2020 · 1 comment · Fixed by #2324

Comments

@Met7
Copy link

Met7 commented Aug 8, 2020

The events example still has underscores at parameters.
https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/CODE_STYLE.md

@julianmrodri
Copy link
Contributor

I checked the contracts and it is true that we are not using underscore for Event parameters. I submitted a PR to change this example. @abcoathup @nventuro @frangio Feel free to review. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants