Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More map types in EnumerableMap #4713

Closed
RyanRHall opened this issue Oct 30, 2023 · 1 comment · Fixed by #4843
Closed

More map types in EnumerableMap #4713

RyanRHall opened this issue Oct 30, 2023 · 1 comment · Fixed by #4843
Milestone

Comments

@RyanRHall
Copy link

🧐 Motivation
Small feature request, but I would love if EnumerableMap would support an address => bytes32 and a uint256 => bytes32 mapping. I have several cases where this has been useful and I end up using a Bytes32ToBytes32Map and then casting the key to the type I want. It works fine, but it would be cleaner if we supported the more specific types :). Happy to help contribute the changes!

📝 Details
Hopefully the motivation section is sufficiently clear :)

@ernestognw
Copy link
Member

ernestognw commented Nov 3, 2023

Hey @RyanRHall , I've seen a few Code4rena projects in the past using variations of EnumerableMap. This is relatively easy to implement since all variants come from a single template and perhaps there's demand.

I'm adding a 5.x tag to consider this for future releases if a good discussion comes up from here.

Note that any modification shouldn't be considered audited even if the other variants already are.

@ernestognw ernestognw added this to the 5.x milestone Nov 3, 2023
@Amxx Amxx mentioned this issue Jan 18, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants