Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address.sendValue doesn't bubble errors #5184

Open
CodeSandwich opened this issue Sep 3, 2024 · 0 comments
Open

Address.sendValue doesn't bubble errors #5184

CodeSandwich opened this issue Sep 3, 2024 · 0 comments

Comments

@CodeSandwich
Copy link
Contributor

CodeSandwich commented Sep 3, 2024

📝 Details

Address.sendValue ignores errors coming from the value recipient and throws a custom error on failure. This doesn't seem very useful, when a smart contract receive reverts, it probably has some important details to share about the failure. It seems that the functionCall error handling would be better here, bubble the original error and throw a generic one only if the contract has absolutely no details to share.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant