From aee78d59fb0ffdf8c965098c05d87ac1c0b2ba7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Venturo?= Date: Thu, 18 Oct 2018 16:48:41 -0300 Subject: [PATCH] Now setting the finalized flag before doing finalization to prevent possbile reentrancy issues. --- contracts/crowdsale/distribution/FinalizableCrowdsale.sol | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/contracts/crowdsale/distribution/FinalizableCrowdsale.sol b/contracts/crowdsale/distribution/FinalizableCrowdsale.sol index a640dca8373..bc9089b4aa4 100644 --- a/contracts/crowdsale/distribution/FinalizableCrowdsale.sol +++ b/contracts/crowdsale/distribution/FinalizableCrowdsale.sol @@ -34,10 +34,10 @@ contract FinalizableCrowdsale is TimedCrowdsale { require(!_finalized); require(hasClosed()); + _finalized = true; + _finalization(); emit CrowdsaleFinalized(); - - _finalized = true; } /** @@ -47,5 +47,4 @@ contract FinalizableCrowdsale is TimedCrowdsale { */ function _finalization() internal { } - }