Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support importing an implementation contract #594

Closed
ericglau opened this issue Jun 14, 2022 · 1 comment
Closed

Support importing an implementation contract #594

ericglau opened this issue Jun 14, 2022 · 1 comment

Comments

@ericglau
Copy link
Member

ericglau commented Jun 14, 2022

forceImport only supports importing a proxy or beacon. Enhance this to support importing an implementation contract.

Example use case:

  1. User previously deployed implementation contract manually
  2. Import implementation contract so it will be in the manifest
  3. Run defender.proposeUpgrade to propose an upgrade -- if the contract was imported above, it would not need be redeployed

Consider a new function forceImportImplementation separate from forceImport, to avoid users accidentally importing a proxy as an implementation. Use the same forceImport function for simplicity. Contract will only be imported as an implementation if it is not detected as a proxy or beacon.

@ericglau ericglau changed the title Support forceImport for an implementation contract Support importing an implementation contract Jun 14, 2022
@ericglau
Copy link
Member Author

Will be handled as part of #580

@ericglau ericglau closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant