Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Newtonsoft.Json to System.Text.Json #14456

Closed
sarahelsaig opened this issue Oct 8, 2023 · 10 comments · Fixed by #14572
Closed

Migrate from Newtonsoft.Json to System.Text.Json #14456

sarahelsaig opened this issue Oct 8, 2023 · 10 comments · Fixed by #14572
Assignees
Milestone

Comments

@sarahelsaig
Copy link
Contributor

I've noticed there isn't a public issue to track what needs to be done to move over from Json.NET to STJ. I'd like to collect all information into one issue to see if/when this move will be possible and what it will entail, so please chime in. This is also research for OrchardCMS/OrchardCore.Commerce#362.

Blockers

Can we collect any dependencies outside of OC that block this move? Here is what I know of so far:

Things to Change

@MikeAlhayek
Copy link
Member

We have been slowly migrating to System.Text.Json in OC. Feel free to submit PRs that would convert.

@hishamco
Copy link
Member

hishamco commented Oct 8, 2023

@MikeAlhayek I will start a PR on sebastienros/yessql#227 then we can work here too to avoid any consequences

@sarahelsaig
Copy link
Contributor Author

Feel free to submit PRs that would convert.

Sure, that's my plan. I just opened this issue to check if there are any known blockers I might have missed, and to know if someone may already be working on this.

@hishamco
Copy link
Member

hishamco commented Oct 8, 2023

@DAud-IcI do you want work on this or we might work together to make this done

@sarahelsaig
Copy link
Contributor Author

We can work together too, whatever is fastest.

@hishamco
Copy link
Member

hishamco commented Oct 8, 2023

I started working on the Converters

@sebastienros
Copy link
Member

Really looking forward to it, thanks to all for working on this.

@sebastienros sebastienros added this to the 1.x milestone Oct 19, 2023
@Piedone
Copy link
Member

Piedone commented Mar 13, 2024

This was done in #14572.

@Piedone Piedone closed this as completed Mar 13, 2024
@MikeAlhayek
Copy link
Member

Also, in the 1.9 release notes we tried to document all the required steps under the breaking changes section ti help users migrate successfully.

@MikeAlhayek
Copy link
Member

Here is the reference to the 1.9.0 release notes
https://docs.orchardcore.net/en/latest/docs/releases/1.9.0/

@MikeAlhayek MikeAlhayek modified the milestones: 2.x, 2.0 Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants