-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from Newtonsoft.Json to System.Text.Json #14456
Comments
We have been slowly migrating to System.Text.Json in OC. Feel free to submit PRs that would convert. |
@MikeAlhayek I will start a PR on sebastienros/yessql#227 then we can work here too to avoid any consequences |
Sure, that's my plan. I just opened this issue to check if there are any known blockers I might have missed, and to know if someone may already be working on this. |
@DAud-IcI do you want work on this or we might work together to make this done |
We can work together too, whatever is fastest. |
I started working on the Converters |
Really looking forward to it, thanks to all for working on this. |
This was done in #14572. |
Also, in the 1.9 release notes we tried to document all the required steps under the breaking changes section ti help users migrate successfully. |
Here is the reference to the 1.9.0 release notes |
I've noticed there isn't a public issue to track what needs to be done to move over from Json.NET to STJ. I'd like to collect all information into one issue to see if/when this move will be possible and what it will entail, so please chime in. This is also research for OrchardCMS/OrchardCore.Commerce#362.
Blockers
Can we collect any dependencies outside of OC that block this move? Here is what I know of so far:
Things to Change
Newtonsoft.Json.Linq
(JToken
,JObject
,JArray
) usages that can be trivially converted to theirSystem.Text.Json.Nodes
counterparts.OrchardCore.ContentManagement.ContentItemConverter
OrchardCore.DisplayManagement.Notify.NotifyEntryConverter
OrchardCore.Workflows.Abstractions.Converters.LocalizedStringConverter
The text was updated successfully, but these errors were encountered: