The method PositionWrapper.AddAsync not implemented.

[MikeAlhayek]

I am seeing this in my log file

115365:2023-12-14 14:35:45.3067|us|00-52e8d3559962e864e6b802b71da88ff3-e95ca432b6052d61-00||Microsoft.AspNetCore.Diagnostics.ExceptionHandlerMiddleware|ERROR|An exception was thrown attempting to execute the error handler. System.NotImplementedException: The method or operation is not implemented.
115366-   at OrchardCore.DisplayManagement.PositionWrapper.AddAsync(Object item, String position)
115367-   at OrchardCore.DisplayManagement.Theming.ThemeLayout.ExecuteAsync()

The methosd AddAsync is indeed not implemented.

OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/PositionWrapper.cs

Line 51 in d6fb9e9

throw new System.NotImplementedException();

I do not see a note why it should not be implemented. The AddAsync method seems to be called by the ThemeLayout.ExecuteAsync

OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Theming/ThemeLayout.cs

Line 27 in d6fb9e9

await ThemeLayout.Zones["Content"].AddAsync(body);

I think it should be implemented.

[MikeAlhayek]

Maybe same implementation as the one we have here

OrchardCore/src/OrchardCore/OrchardCore.DisplayManagement/Views/ShapeViewModel.cs

Line 11 in 5a26240

public class ShapeViewModel : IShape, IPositioned

[sebastienros]

I am wondering why a Zone ("Content") is wrapped in a PositionWrapper in the first place. PositionWrapper is done for shapes that don't have a Position property, like "strings". This is why it's not implemented. We need to understand when it get wrapped.

[ns8482e]

@MikeAlhayek PositionWrapper is used to wrap pre-rendered items like IHtmlContent and string and shape should not be used with PositionWrapper.

AddAsync not implemented is intentional and PositionWrapper should not contain any items.

[MikeAlhayek]

Yeah. Too bad how can't recall how to reproduce the issue. Something was calling that method.

[sebastienros]

Please re-open when you can repro.